Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(791)

Unified Diff: test/unittests/run-all-unittests.cc

Issue 1412223018: [presubmit] Enabling readability/inheritance linter checking. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressing comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/unittests/libplatform/task-queue-unittest.cc ('k') | tools/presubmit.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/run-all-unittests.cc
diff --git a/test/unittests/run-all-unittests.cc b/test/unittests/run-all-unittests.cc
index 0b7f65e08e19394a9fccf8018ca0d2404e8d321f..0b62dbff2b41a426ba29662455125c02ccb6c23b 100644
--- a/test/unittests/run-all-unittests.cc
+++ b/test/unittests/run-all-unittests.cc
@@ -12,9 +12,8 @@ namespace {
class DefaultPlatformEnvironment final : public ::testing::Environment {
public:
DefaultPlatformEnvironment() : platform_(NULL) {}
- ~DefaultPlatformEnvironment() {}
- virtual void SetUp() override {
+ void SetUp() override {
EXPECT_EQ(NULL, platform_);
platform_ = v8::platform::CreateDefaultPlatform();
ASSERT_TRUE(platform_ != NULL);
@@ -22,7 +21,7 @@ class DefaultPlatformEnvironment final : public ::testing::Environment {
ASSERT_TRUE(v8::V8::Initialize());
}
- virtual void TearDown() override {
+ void TearDown() override {
ASSERT_TRUE(platform_ != NULL);
v8::V8::Dispose();
v8::V8::ShutdownPlatform();
« no previous file with comments | « test/unittests/libplatform/task-queue-unittest.cc ('k') | tools/presubmit.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698