Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: test/unittests/base/platform/semaphore-unittest.cc

Issue 1412223018: [presubmit] Enabling readability/inheritance linter checking. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressing comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/unittests/base/platform/semaphore-unittest.cc
diff --git a/test/unittests/base/platform/semaphore-unittest.cc b/test/unittests/base/platform/semaphore-unittest.cc
index 9565e0e213d606f242cb44e4b0592f737c2f3ece..bd4a00fe95b8150e43c08219921f55675dd2597c 100644
--- a/test/unittests/base/platform/semaphore-unittest.cc
+++ b/test/unittests/base/platform/semaphore-unittest.cc
@@ -27,9 +27,8 @@ class ProducerThread final : public Thread {
buffer_(buffer),
free_space_(free_space),
used_space_(used_space) {}
- virtual ~ProducerThread() {}
- virtual void Run() override {
+ void Run() override {
for (size_t n = 0; n < kDataSize; ++n) {
free_space_->Wait();
buffer_[n % kBufferSize] = kAlphabet[n % kAlphabetSize];
@@ -52,9 +51,8 @@ class ConsumerThread final : public Thread {
buffer_(buffer),
free_space_(free_space),
used_space_(used_space) {}
- virtual ~ConsumerThread() {}
- virtual void Run() override {
+ void Run() override {
for (size_t n = 0; n < kDataSize; ++n) {
used_space_->Wait();
EXPECT_EQ(kAlphabet[n % kAlphabetSize], buffer_[n % kBufferSize]);
@@ -73,9 +71,8 @@ class WaitAndSignalThread final : public Thread {
public:
explicit WaitAndSignalThread(Semaphore* semaphore)
: Thread(Options("WaitAndSignalThread")), semaphore_(semaphore) {}
- virtual ~WaitAndSignalThread() {}
- virtual void Run() override {
+ void Run() override {
for (int n = 0; n < 100; ++n) {
semaphore_->Wait();
ASSERT_FALSE(semaphore_->WaitFor(TimeDelta::FromMicroseconds(1)));
« no previous file with comments | « test/unittests/base/platform/condition-variable-unittest.cc ('k') | test/unittests/libplatform/task-queue-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698