src/rewriter.cc - Issue 1412223018: [presubmit] Enabling readability/inheritance linter checking.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/rewriter.cc

Issue 1412223018: [presubmit] Enabling readability/inheritance linter checking. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Addressing comments Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/rewriter.cc

diff --git a/src/rewriter.cc b/src/rewriter.cc

index 47843305390bd6506b2b9fa8079e569a5cb0828b..1f19739331e09feefcf5b75f352f8fa5729a31e4 100644

--- a/src/rewriter.cc

+++ b/src/rewriter.cc

@@ -36,7 +36,7 @@ class Processor: public AstVisitor {

InitializeAstVisitor(parser->stack_limit());

}

- virtual ~Processor() { }

+ ~Processor() override {}

void Process(ZoneList<Statement*>* statements);

bool result_assigned() const { return result_assigned_; }

@@ -80,7 +80,7 @@ class Processor: public AstVisitor {

AstNodeFactory factory_;

// Node visitors.

-#define DEF_VISIT(type) virtual void Visit##type(type* node) override;

+#define DEF_VISIT(type) void Visit##type(type* node) override;

AST_NODE_LIST(DEF_VISIT)

#undef DEF_VISIT

« no previous file with comments | « src/parser.h ('k') | src/scanner-character-streams.h » ('j') | no next file with comments »