src/ast.cc - Issue 1412223018: [presubmit] Enabling readability/inheritance linter checking.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ast.cc

Issue 1412223018: [presubmit] Enabling readability/inheritance linter checking. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Addressing comments Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ast.cc

diff --git a/src/ast.cc b/src/ast.cc

index ca0a7465b12e61d77d2a9b069da79100d4da18fa..b5c6cf57ea417cf8a70e266ac83bf82e72d31734 100644

--- a/src/ast.cc

+++ b/src/ast.cc

@@ -942,8 +942,7 @@ class RegExpUnparser final : public RegExpVisitor {

public:

RegExpUnparser(std::ostream& os, Zone* zone) : os_(os), zone_(zone) {}

void VisitCharacterRange(CharacterRange that);

-#define MAKE_CASE(Name) \

- virtual void* Visit##Name(RegExp##Name*, void* data) override;

+#define MAKE_CASE(Name) void* Visit##Name(RegExp##Name*, void* data) override;

FOR_EACH_REG_EXP_TREE_TYPE(MAKE_CASE)

#undef MAKE_CASE

private:

« no previous file with comments | « src/ast.h ('k') | src/ast-expression-visitor.h » ('j') | no next file with comments »