Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: src/crankshaft/hydrogen.h

Issue 1412223018: [presubmit] Enabling readability/inheritance linter checking. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressing comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/ast-graph-builder.cc ('k') | src/crankshaft/hydrogen-instructions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/crankshaft/hydrogen.h
diff --git a/src/crankshaft/hydrogen.h b/src/crankshaft/hydrogen.h
index 24c5ca86eb0f8c08c5098753d9dc53312425b820..b141c99fc060df2963c11c6ba8fbd8e0c6037863 100644
--- a/src/crankshaft/hydrogen.h
+++ b/src/crankshaft/hydrogen.h
@@ -788,15 +788,13 @@ class EffectContext final : public AstContext {
explicit EffectContext(HOptimizedGraphBuilder* owner)
: AstContext(owner, Expression::kEffect) {
}
- virtual ~EffectContext();
+ ~EffectContext() override;
void ReturnValue(HValue* value) override;
- virtual void ReturnInstruction(HInstruction* instr,
- BailoutId ast_id) override;
- virtual void ReturnControl(HControlInstruction* instr,
- BailoutId ast_id) override;
- virtual void ReturnContinuation(HIfContinuation* continuation,
- BailoutId ast_id) override;
+ void ReturnInstruction(HInstruction* instr, BailoutId ast_id) override;
+ void ReturnControl(HControlInstruction* instr, BailoutId ast_id) override;
+ void ReturnContinuation(HIfContinuation* continuation,
+ BailoutId ast_id) override;
};
@@ -805,15 +803,13 @@ class ValueContext final : public AstContext {
ValueContext(HOptimizedGraphBuilder* owner, ArgumentsAllowedFlag flag)
: AstContext(owner, Expression::kValue), flag_(flag) {
}
- virtual ~ValueContext();
+ ~ValueContext() override;
void ReturnValue(HValue* value) override;
- virtual void ReturnInstruction(HInstruction* instr,
- BailoutId ast_id) override;
- virtual void ReturnControl(HControlInstruction* instr,
- BailoutId ast_id) override;
- virtual void ReturnContinuation(HIfContinuation* continuation,
- BailoutId ast_id) override;
+ void ReturnInstruction(HInstruction* instr, BailoutId ast_id) override;
+ void ReturnControl(HControlInstruction* instr, BailoutId ast_id) override;
+ void ReturnContinuation(HIfContinuation* continuation,
+ BailoutId ast_id) override;
bool arguments_allowed() { return flag_ == ARGUMENTS_ALLOWED; }
@@ -835,12 +831,10 @@ class TestContext final : public AstContext {
}
void ReturnValue(HValue* value) override;
- virtual void ReturnInstruction(HInstruction* instr,
- BailoutId ast_id) override;
- virtual void ReturnControl(HControlInstruction* instr,
- BailoutId ast_id) override;
- virtual void ReturnContinuation(HIfContinuation* continuation,
- BailoutId ast_id) override;
+ void ReturnInstruction(HInstruction* instr, BailoutId ast_id) override;
+ void ReturnControl(HControlInstruction* instr, BailoutId ast_id) override;
+ void ReturnContinuation(HIfContinuation* continuation,
+ BailoutId ast_id) override;
static TestContext* cast(AstContext* context) {
DCHECK(context->IsTest());
@@ -2392,7 +2386,7 @@ class HOptimizedGraphBuilder : public HGraphBuilder, public AstVisitor {
void SetUpScope(Scope* scope);
void VisitStatements(ZoneList<Statement*>* statements) override;
-#define DECLARE_VISIT(type) virtual void Visit##type(type* node) override;
+#define DECLARE_VISIT(type) void Visit##type(type* node) override;
AST_NODE_LIST(DECLARE_VISIT)
#undef DECLARE_VISIT
« no previous file with comments | « src/compiler/ast-graph-builder.cc ('k') | src/crankshaft/hydrogen-instructions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698