src/ast-numbering.cc - Issue 1412223018: [presubmit] Enabling readability/inheritance linter checking.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ast-numbering.cc

Issue 1412223018: [presubmit] Enabling readability/inheritance linter checking. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Addressing comments Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ast-numbering.cc

diff --git a/src/ast-numbering.cc b/src/ast-numbering.cc

index fb0df634e7a208469b9bb97b718a2c12998630d9..8479191b5e9b44cfd00cf1b5010401f4f666966b 100644

--- a/src/ast-numbering.cc

+++ b/src/ast-numbering.cc

@@ -27,7 +27,7 @@ class AstNumberingVisitor final : public AstVisitor {

private:

// AST node visitor interface.

-#define DEFINE_VISIT(type) virtual void Visit##type(type* node) override;

+#define DEFINE_VISIT(type) void Visit##type(type* node) override;

AST_NODE_LIST(DEFINE_VISIT)

#undef DEFINE_VISIT

« no previous file with comments | « src/ast-literal-reindexer.h ('k') | src/code-stubs.h » ('j') | no next file with comments »