Move Hydrogen and Lithium to src/crankshaft/

Move Hydrogen and Lithium to src/crankshaft/

Committed: https://crrev.com/81ee94b6507cf3ee9d44d18b8ccb1f1cc9045be1
Cr-Commit-Position: refs/heads/master@{#31410}

[Jakob Kummerow, 2015-10-16 16:02:18]

Entirely mechanical change:
- moved files
- fixed #includes and header include guards
- updated BUILD.gn and v8.gyp
- verified that it compiles on ia32, x64, arm, arm64, mipsel, mips64el, ppc.
(x87 was broken before)

[Jakob Kummerow, 2015-10-16 16:02:40]

The CQ bit was checked by jkummerow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-16 16:03:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1405363003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1405363003/1

[commit-bot: I haz the power, 2015-10-16 16:55:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-16 16:55:10]

Dry run: This issue passed the CQ dry run.

[Jakob Kummerow, 2015-10-19 17:14:49]

jkummerow@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Jakob Kummerow, 2015-10-19 17:14:50]

I can haz review plz?

[Michael Starzinger, 2015-10-19 17:50:07]

LGTM after comment about OWNERS file is addressed.

https://codereview.chromium.org/1405363003/diff/1/src/crankshaft/OWNERS
File src/crankshaft/OWNERS (right):

https://codereview.chromium.org/1405363003/diff/1/src/crankshaft/OWNERS#newcode7
src/crankshaft/OWNERS:7: mstarzinger@chromium.org
Please move adding of OWNERS files into a separate CL and add the appropriate
reviewers. I, for one, don't want to be a Crankshaft owner.

https://codereview.chromium.org/1405363003/diff/1/src/isolate.cc
File src/isolate.cc (right):

https://codereview.chromium.org/1405363003/diff/1/src/isolate.cc#newcode21
src/isolate.cc:21: #include "src/crankshaft/hydrogen.h"  // For HStatistics and
HTracer.
nit: I am not a huge fan of the comments after includes. They tend to get out of
date and don't add much value IMHO. Would you be fine with dropping it?

[Jakob Kummerow, 2015-10-20 12:10:48]

Thanks for the review. Addressed your comments.

https://codereview.chromium.org/1405363003/diff/1/src/crankshaft/OWNERS
File src/crankshaft/OWNERS (right):

https://codereview.chromium.org/1405363003/diff/1/src/crankshaft/OWNERS#newcode7
src/crankshaft/OWNERS:7: mstarzinger@chromium.org
On 2015/10/19 17:50:07, Michael Starzinger wrote:
> Please move adding of OWNERS files into a separate CL and add the appropriate
> reviewers. I, for one, don't want to be a Crankshaft owner.

Done.

https://codereview.chromium.org/1405363003/diff/1/src/isolate.cc
File src/isolate.cc (right):

https://codereview.chromium.org/1405363003/diff/1/src/isolate.cc#newcode21
src/isolate.cc:21: #include "src/crankshaft/hydrogen.h"  // For HStatistics and
HTracer.
On 2015/10/19 17:50:07, Michael Starzinger wrote:
> nit: I am not a huge fan of the comments after includes. They tend to get out
of
> date and don't add much value IMHO. Would you be fine with dropping it?

Done. (I agree in general; the motivation for adding this comment was that I
found it surprising that the #include was required, so it seemed worthwhile to
document the reason.)

[Jakob Kummerow, 2015-10-20 12:25:08]

The CQ bit was checked by jkummerow@chromium.org

[Jakob Kummerow, 2015-10-20 12:25:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1405363003/#ps20001
(title: "rebased")

[commit-bot: I haz the power, 2015-10-20 12:25:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1405363003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1405363003/20001

[commit-bot: I haz the power, 2015-10-20 13:25:55]

Committed patchset #3 (id:20001)

[commit-bot: I haz the power, 2015-10-20 13:26:06]

Patchset 3 (id:??) landed as
https://crrev.com/81ee94b6507cf3ee9d44d18b8ccb1f1cc9045be1
Cr-Commit-Position: refs/heads/master@{#31410}