Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issue 1387573003: Pass SkiaImageFilterBuilder& to FilterEffect::createImageFilter (Closed)

Created:
5 years, 2 months ago by fs
Modified:
5 years, 2 months ago
Reviewers:
pdr., Stephen White
CC:
blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), fs, gyuyoung2, jbroman, Justin Novosad, kouhei+svg_chromium.org, pdr+graphicswatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass SkiaImageFilterBuilder& to FilterEffect::createImageFilter The builder should never be null, so just make it a reference. Drop the builder arguments on SVGFEImage::createImageFilterForLayoutObject because it's unused, and make the LayoutObject& const while touching those lines. Make createImageFilter overrides private. Committed: https://crrev.com/3f2605089ceb0bb292c09a10700ef1369569a547 Cr-Commit-Position: refs/heads/master@{#352543}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -94 lines) Patch
M third_party/WebKit/Source/core/svg/graphics/filters/SVGFEImage.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/filters/SVGFEImage.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEBlend.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEBlend.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEColorMatrix.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEColorMatrix.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEComponentTransfer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEComponentTransfer.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEComposite.h View 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEComposite.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEDisplacementMap.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEDisplacementMap.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEDropShadow.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEDropShadow.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEFlood.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEFlood.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEGaussianBlur.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEGaussianBlur.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FELighting.h View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FELighting.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEMerge.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEMerge.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEMorphology.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEMorphology.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEOffset.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEOffset.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FETile.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FETile.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FETurbulence.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FETurbulence.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FilterEffect.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/SourceAlpha.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/SourceAlpha.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/SourceGraphic.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/SourceGraphic.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
fs
Pretty mechanical this one.
5 years, 2 months ago (2015-10-02 15:00:09 UTC) #3
pdr.
LGTM
5 years, 2 months ago (2015-10-06 03:36:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1387573003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1387573003/1
5 years, 2 months ago (2015-10-06 03:38:01 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-06 05:54:50 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-06 05:55:36 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3f2605089ceb0bb292c09a10700ef1369569a547
Cr-Commit-Position: refs/heads/master@{#352543}

Powered by Google App Engine
This is Rietveld 408576698