third_party/WebKit/Source/platform/graphics/filters/FEComposite.h - Issue 1387573003: Pass SkiaImageFilterBuilder& to FilterEffect::createImageFilter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/FEComposite.h

Issue 1387573003: Pass SkiaImageFilterBuilder& to FilterEffect::createImageFilter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/filters/FEComponentTransfer.cpp ('k') | third_party/WebKit/Source/platform/graphics/filters/FEComposite.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/filters/FEComposite.h

diff --git a/third_party/WebKit/Source/platform/graphics/filters/FEComposite.h b/third_party/WebKit/Source/platform/graphics/filters/FEComposite.h

index f7b7302dde64ea81c2fc4032cf415fd397040d91..1aefe3c5752b6bf4d1b4fc72f253cfb69dd053c6 100644

--- a/third_party/WebKit/Source/platform/graphics/filters/FEComposite.h

+++ b/third_party/WebKit/Source/platform/graphics/filters/FEComposite.h

@@ -62,16 +62,15 @@ public:

TextStream& externalRepresentation(TextStream&, int indention) const override;

- PassRefPtr<SkImageFilter> createImageFilter(SkiaImageFilterBuilder*) override;

- PassRefPtr<SkImageFilter> createImageFilterWithoutValidation(SkiaImageFilterBuilder*) override;

protected:

bool mayProduceInvalidPreMultipliedPixels() override { return m_type == FECOMPOSITE_OPERATOR_ARITHMETIC; }

private:

FEComposite(Filter*, const CompositeOperationType&, float, float, float, float);

- PassRefPtr<SkImageFilter> createImageFilterInternal(SkiaImageFilterBuilder*, bool requiresPMColorValidation);

+ PassRefPtr<SkImageFilter> createImageFilter(SkiaImageFilterBuilder&) override;

+ PassRefPtr<SkImageFilter> createImageFilterWithoutValidation(SkiaImageFilterBuilder&) override;

+ PassRefPtr<SkImageFilter> createImageFilterInternal(SkiaImageFilterBuilder&, bool requiresPMColorValidation);

CompositeOperationType m_type;

float m_k1;