third_party/WebKit/Source/platform/graphics/filters/FEMorphology.cpp - Issue 1387573003: Pass SkiaImageFilterBuilder& to FilterEffect::createImageFilter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/FEMorphology.cpp

Issue 1387573003: Pass SkiaImageFilterBuilder& to FilterEffect::createImageFilter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/filters/FEMorphology.h ('k') | third_party/WebKit/Source/platform/graphics/filters/FEOffset.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/filters/FEMorphology.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/filters/FEMorphology.cpp b/third_party/WebKit/Source/platform/graphics/filters/FEMorphology.cpp

index bfd2ebcbd11039b4b8abfd40bf56f3243fd7954a..3ffde188417de94cf6439c087447ff7715aee6a6 100644

--- a/third_party/WebKit/Source/platform/graphics/filters/FEMorphology.cpp

+++ b/third_party/WebKit/Source/platform/graphics/filters/FEMorphology.cpp

@@ -94,12 +94,12 @@ FloatRect FEMorphology::mapRect(const FloatRect& rect, bool)

return result;

}

-PassRefPtr<SkImageFilter> FEMorphology::createImageFilter(SkiaImageFilterBuilder* builder)

+PassRefPtr<SkImageFilter> FEMorphology::createImageFilter(SkiaImageFilterBuilder& builder)

{

- RefPtr<SkImageFilter> input(builder->build(inputEffect(0), operatingColorSpace()));

+ RefPtr<SkImageFilter> input(builder.build(inputEffect(0), operatingColorSpace()));

SkScalar radiusX = SkFloatToScalar(filter()->applyHorizontalScale(m_radiusX));

SkScalar radiusY = SkFloatToScalar(filter()->applyVerticalScale(m_radiusY));

- SkImageFilter::CropRect rect = getCropRect(builder->cropOffset());

+ SkImageFilter::CropRect rect = getCropRect(builder.cropOffset());

if (m_type == FEMORPHOLOGY_OPERATOR_DILATE)

return adoptRef(SkDilateImageFilter::Create(radiusX, radiusY, input.get(), &rect));

return adoptRef(SkErodeImageFilter::Create(radiusX, radiusY, input.get(), &rect));