third_party/WebKit/Source/platform/graphics/filters/FELighting.h - Issue 1387573003: Pass SkiaImageFilterBuilder& to FilterEffect::createImageFilter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/FELighting.h

Issue 1387573003: Pass SkiaImageFilterBuilder& to FilterEffect::createImageFilter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/filters/FEGaussianBlur.cpp ('k') | third_party/WebKit/Source/platform/graphics/filters/FELighting.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/filters/FELighting.h

diff --git a/third_party/WebKit/Source/platform/graphics/filters/FELighting.h b/third_party/WebKit/Source/platform/graphics/filters/FELighting.h

index b9e88c0b7cc8aa49511c3c3a426e866cdeddb5f8..e27ef9a9dcd60bc8bd30baf7e7a65bf37d4bde77 100644

--- a/third_party/WebKit/Source/platform/graphics/filters/FELighting.h

+++ b/third_party/WebKit/Source/platform/graphics/filters/FELighting.h

@@ -38,15 +38,14 @@ namespace blink {

class LightSource;

class PLATFORM_EXPORT FELighting : public FilterEffect {

-public:

- PassRefPtr<SkImageFilter> createImageFilter(SkiaImageFilterBuilder*) override;

protected:

enum LightingType {

DiffuseLighting,

SpecularLighting

};

+ PassRefPtr<SkImageFilter> createImageFilter(SkiaImageFilterBuilder&) override;

FloatRect mapPaintRect(const FloatRect&, bool forward = true) final;

bool affectsTransparentPixels() override { return true; }