Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Side by Side Diff: third_party/WebKit/Source/platform/graphics/filters/FilterEffect.cpp

Issue 1387573003: Pass SkiaImageFilterBuilder& to FilterEffect::createImageFilter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Alex Mathews <possessedpenguinbob@gmail.com> 2 * Copyright (C) 2008 Alex Mathews <possessedpenguinbob@gmail.com>
3 * Copyright (C) 2009 Dirk Schulze <krit@webkit.org> 3 * Copyright (C) 2009 Dirk Schulze <krit@webkit.org>
4 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 4 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
5 * Copyright (C) 2012 University of Szeged 5 * Copyright (C) 2012 University of Szeged
6 * Copyright (C) 2013 Google Inc. All rights reserved. 6 * Copyright (C) 2013 Google Inc. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 165 matching lines...) Expand 10 before | Expand all | Expand 10 after
176 176
177 // Clip every filter effect to the filter region. 177 // Clip every filter effect to the filter region.
178 if (flags & ClipToFilterRegion) { 178 if (flags & ClipToFilterRegion) {
179 absoluteSubregion.intersect(filter->absoluteFilterRegion()); 179 absoluteSubregion.intersect(filter->absoluteFilterRegion());
180 } 180 }
181 181
182 setMaxEffectRect(absoluteSubregion); 182 setMaxEffectRect(absoluteSubregion);
183 return subregion; 183 return subregion;
184 } 184 }
185 185
186 PassRefPtr<SkImageFilter> FilterEffect::createImageFilter(SkiaImageFilterBuilder * builder) 186 PassRefPtr<SkImageFilter> FilterEffect::createImageFilter(SkiaImageFilterBuilder & builder)
187 { 187 {
188 return nullptr; 188 return nullptr;
189 } 189 }
190 190
191 PassRefPtr<SkImageFilter> FilterEffect::createImageFilterWithoutValidation(SkiaI mageFilterBuilder* builder) 191 PassRefPtr<SkImageFilter> FilterEffect::createImageFilterWithoutValidation(SkiaI mageFilterBuilder& builder)
192 { 192 {
193 return createImageFilter(builder); 193 return createImageFilter(builder);
194 } 194 }
195 195
196 PassRefPtr<SkImageFilter> FilterEffect::createTransparentBlack(SkiaImageFilterBu ilder* builder) const 196 PassRefPtr<SkImageFilter> FilterEffect::createTransparentBlack(SkiaImageFilterBu ilder& builder) const
197 { 197 {
198 SkAutoTUnref<SkColorFilter> filter(SkColorFilter::CreateModeFilter(0, SkXfer mode::kClear_Mode)); 198 SkAutoTUnref<SkColorFilter> filter(SkColorFilter::CreateModeFilter(0, SkXfer mode::kClear_Mode));
199 SkImageFilter::CropRect rect = getCropRect(builder->cropOffset()); 199 SkImageFilter::CropRect rect = getCropRect(builder.cropOffset());
200 return adoptRef(SkColorFilterImageFilter::Create(filter, nullptr, &rect)); 200 return adoptRef(SkColorFilterImageFilter::Create(filter, nullptr, &rect));
201 } 201 }
202 202
203 bool FilterEffect::hasConnectedInput() const 203 bool FilterEffect::hasConnectedInput() const
204 { 204 {
205 for (unsigned i = 0; i < m_inputEffects.size(); i++) { 205 for (unsigned i = 0; i < m_inputEffects.size(); i++) {
206 if (m_inputEffects[i]) { 206 if (m_inputEffects[i]) {
207 return true; 207 return true;
208 } 208 }
209 } 209 }
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
256 return m_imageFilters[index].get(); 256 return m_imageFilters[index].get();
257 } 257 }
258 258
259 void FilterEffect::setImageFilter(ColorSpace colorSpace, bool requiresPMColorVal idation, PassRefPtr<SkImageFilter> imageFilter) 259 void FilterEffect::setImageFilter(ColorSpace colorSpace, bool requiresPMColorVal idation, PassRefPtr<SkImageFilter> imageFilter)
260 { 260 {
261 int index = getImageFilterIndex(colorSpace, requiresPMColorValidation); 261 int index = getImageFilterIndex(colorSpace, requiresPMColorValidation);
262 m_imageFilters[index] = imageFilter; 262 m_imageFilters[index] = imageFilter;
263 } 263 }
264 264
265 } // namespace blink 265 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698