third_party/WebKit/Source/platform/graphics/filters/FELighting.cpp - Issue 1387573003: Pass SkiaImageFilterBuilder& to FilterEffect::createImageFilter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/FELighting.cpp

Issue 1387573003: Pass SkiaImageFilterBuilder& to FilterEffect::createImageFilter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/filters/FELighting.h ('k') | third_party/WebKit/Source/platform/graphics/filters/FEMerge.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/filters/FELighting.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/filters/FELighting.cpp b/third_party/WebKit/Source/platform/graphics/filters/FELighting.cpp

index 47afd5dc343bf9750fa2cd2b02f8b3e630ebab11..39c7d4683f2aa0ce464bc278f09b6b203440aa18 100644

--- a/third_party/WebKit/Source/platform/graphics/filters/FELighting.cpp

+++ b/third_party/WebKit/Source/platform/graphics/filters/FELighting.cpp

@@ -59,14 +59,14 @@ FloatRect FELighting::mapPaintRect(const FloatRect& rect, bool)

return result;

}

-PassRefPtr<SkImageFilter> FELighting::createImageFilter(SkiaImageFilterBuilder* builder)

+PassRefPtr<SkImageFilter> FELighting::createImageFilter(SkiaImageFilterBuilder& builder)

{

if (!m_lightSource)

return createTransparentBlack(builder);

- SkImageFilter::CropRect rect = getCropRect(builder ? builder->cropOffset() : FloatSize());

+ SkImageFilter::CropRect rect = getCropRect(builder.cropOffset());

Color lightColor = adaptColorToOperatingColorSpace(m_lightingColor);

- RefPtr<SkImageFilter> input(builder ? builder->build(inputEffect(0), operatingColorSpace()) : nullptr);

+ RefPtr<SkImageFilter> input(builder.build(inputEffect(0), operatingColorSpace()));

switch (m_lightSource->type()) {

case LS_DISTANT: {

DistantLightSource* distantLightSource = static_cast<DistantLightSource*>(m_lightSource.get());