third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.h - Issue 1387573003: Pass SkiaImageFilterBuilder& to FilterEffect::createImageFilter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.h

Issue 1387573003: Pass SkiaImageFilterBuilder& to FilterEffect::createImageFilter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/filters/FEComposite.cpp ('k') | third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.h

diff --git a/third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.h b/third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.h

index a80099a2aff29667ba745cf11d6f23962745c7bc..e4cdfc24cf5f0117d2a36c017af6a81d986fa4f3 100644

--- a/third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.h

+++ b/third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.h

@@ -50,8 +50,6 @@ public:

bool setEdgeMode(EdgeModeType);

bool setPreserveAlpha(bool);

- PassRefPtr<SkImageFilter> createImageFilter(SkiaImageFilterBuilder*) override;

FloatRect mapPaintRect(const FloatRect&, bool forward = true) final;

TextStream& externalRepresentation(TextStream&, int indention) const override;

@@ -60,6 +58,8 @@ private:

FEConvolveMatrix(Filter*, const IntSize&, float, float,

const IntPoint&, EdgeModeType, bool, const Vector<float>&);

+ PassRefPtr<SkImageFilter> createImageFilter(SkiaImageFilterBuilder&) override;

bool parametersValid() const;

IntSize m_kernelSize;