third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h - Issue 1387573003: Pass SkiaImageFilterBuilder& to FilterEffect::createImageFilter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h

Issue 1387573003: Pass SkiaImageFilterBuilder& to FilterEffect::createImageFilter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/filters/FETurbulence.cpp ('k') | third_party/WebKit/Source/platform/graphics/filters/FilterEffect.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h

diff --git a/third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h b/third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h

index d1056bc473e5352e21187c024f415e7d70acd1c1..a24e7756fc88d8fb831fcf80590cc94eb124a122 100644

--- a/third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h

+++ b/third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h

@@ -81,8 +81,8 @@ public:

FloatRect maxEffectRect() const { return m_maxEffectRect; }

void setMaxEffectRect(const FloatRect& maxEffectRect) { m_maxEffectRect = maxEffectRect; }

- virtual PassRefPtr<SkImageFilter> createImageFilter(SkiaImageFilterBuilder*);

- virtual PassRefPtr<SkImageFilter> createImageFilterWithoutValidation(SkiaImageFilterBuilder*);

+ virtual PassRefPtr<SkImageFilter> createImageFilter(SkiaImageFilterBuilder&);

+ virtual PassRefPtr<SkImageFilter> createImageFilterWithoutValidation(SkiaImageFilterBuilder&);

// Mapping a rect forwards determines which which destination pixels a

// given source rect would affect. Mapping a rect backwards determines

@@ -149,7 +149,7 @@ public:

protected:

FilterEffect(Filter*);

- PassRefPtr<SkImageFilter> createTransparentBlack(SkiaImageFilterBuilder*) const;

+ PassRefPtr<SkImageFilter> createTransparentBlack(SkiaImageFilterBuilder&) const;

Color adaptColorToOperatingColorSpace(const Color& deviceColor);