third_party/WebKit/Source/platform/graphics/filters/FEDropShadow.cpp - Issue 1387573003: Pass SkiaImageFilterBuilder& to FilterEffect::createImageFilter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/FEDropShadow.cpp

Issue 1387573003: Pass SkiaImageFilterBuilder& to FilterEffect::createImageFilter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/filters/FEDropShadow.h ('k') | third_party/WebKit/Source/platform/graphics/filters/FEFlood.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/filters/FEDropShadow.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/filters/FEDropShadow.cpp b/third_party/WebKit/Source/platform/graphics/filters/FEDropShadow.cpp

index e6fdef32ea02ba061eac56a9f798fbd7642e5375..0087be869f6bb41f2214ff9cbf544571f633f202 100644

--- a/third_party/WebKit/Source/platform/graphics/filters/FEDropShadow.cpp

+++ b/third_party/WebKit/Source/platform/graphics/filters/FEDropShadow.cpp

@@ -66,15 +66,15 @@ FloatRect FEDropShadow::mapRect(const FloatRect& rect, bool forward)

return result;

}

-PassRefPtr<SkImageFilter> FEDropShadow::createImageFilter(SkiaImageFilterBuilder* builder)

+PassRefPtr<SkImageFilter> FEDropShadow::createImageFilter(SkiaImageFilterBuilder& builder)

{

- RefPtr<SkImageFilter> input(builder->build(inputEffect(0), operatingColorSpace()));

+ RefPtr<SkImageFilter> input(builder.build(inputEffect(0), operatingColorSpace()));

float dx = filter()->applyHorizontalScale(m_dx);

float dy = filter()->applyVerticalScale(m_dy);

float stdX = filter()->applyHorizontalScale(m_stdX);

float stdY = filter()->applyVerticalScale(m_stdY);

Color color = adaptColorToOperatingColorSpace(m_shadowColor.combineWithAlpha(m_shadowOpacity));

- SkImageFilter::CropRect cropRect = getCropRect(builder->cropOffset());

+ SkImageFilter::CropRect cropRect = getCropRect(builder.cropOffset());

return adoptRef(SkDropShadowImageFilter::Create(SkFloatToScalar(dx), SkFloatToScalar(dy), SkFloatToScalar(stdX), SkFloatToScalar(stdY), color.rgb(), SkDropShadowImageFilter::kDrawShadowAndForeground_ShadowMode, input.get(), &cropRect));

}