Issue 1361223003: Enforce marking "override" for functions overriding Blink in components/.

Issue 1361223003: Enforce marking "override" for functions overriding Blink in components/. (Closed)

Created:
5 years, 2 months ago by Avi (use Gerrit)

Modified:
5 years, 2 months ago

Reviewers:
blundell

CC:
chromium-reviews, mlamouri+watch-content_chromium.org, rouslan+autofill_chromium.org, jam, vabr+watchlist_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, bondd+autofillwatch_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, scheduler-bugs_chromium.org, mkwst+watchlist-passwords_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Mark functions overriding Blink with "override" in components/. BUG=535367 TEST=it all stays working Committed: https://crrev.com/1e950bb73ce3e1882f6c82863609ff38fc51ca73 Cr-Commit-Position: refs/heads/master@{#351032}

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+103 lines, -108 lines)			Patch
M	components/autofill/content/renderer/autofill_agent.h	View	2 chunks	+13 lines, -16 lines	0 comments	Download
M	components/message_port/web_message_port_channel_impl.h	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	components/nacl/renderer/file_downloader.h	View	1 chunk	+12 lines, -12 lines	0 comments	Download
M	components/nacl/renderer/manifest_downloader.h	View	2 chunks	+12 lines, -12 lines	0 comments	Download
M	components/network_hints/renderer/prescient_networking_dispatcher.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	components/password_manager/content/renderer/credential_manager_client.h	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	components/password_manager/content/renderer/credential_manager_client_browsertest.cc	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	components/plugins/renderer/webview_plugin.h	View	1 chunk	+43 lines, -45 lines	0 comments	Download
M	components/scheduler/child/webthread_impl_for_worker_scheduler_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	components/scheduler/renderer/webthread_impl_for_renderer_scheduler_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 11 (4 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361223003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361223003/1

5 years, 2 months ago (2015-09-25 21:07:35 UTC) #2

commit-bot: I haz the power

Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/109151)

5 years, 2 months ago (2015-09-25 22:27:15 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361223003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361223003/1

5 years, 2 months ago (2015-09-28 07:18:20 UTC) #9

commit-bot: I haz the power

5 years, 2 months ago (2015-09-28 08:14:10 UTC) #11

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/1e950bb73ce3e1882f6c82863609ff38fc51ca73
Cr-Commit-Position: refs/heads/master@{#351032}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages