components/network_hints/renderer/prescient_networking_dispatcher.h - Issue 1361223003: Enforce marking "override" for functions overriding Blink in components/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/network_hints/renderer/prescient_networking_dispatcher.h

Issue 1361223003: Enforce marking "override" for functions overriding Blink in components/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/nacl/renderer/manifest_downloader.h ('k') | components/password_manager/content/renderer/credential_manager_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/network_hints/renderer/prescient_networking_dispatcher.h

diff --git a/components/network_hints/renderer/prescient_networking_dispatcher.h b/components/network_hints/renderer/prescient_networking_dispatcher.h

index d3159a9dbf9b80b939812b2485b4bd827a80c7c4..a4e7ecd88028a6a5c1a88a1d14311236a0ee3d3c 100644

--- a/components/network_hints/renderer/prescient_networking_dispatcher.h

+++ b/components/network_hints/renderer/prescient_networking_dispatcher.h

@@ -19,9 +19,9 @@ class PrescientNetworkingDispatcher : public blink::WebPrescientNetworking {

PrescientNetworkingDispatcher();

~PrescientNetworkingDispatcher() override;

- virtual void prefetchDNS(const blink::WebString& hostname) override;

- virtual void preconnect(const blink::WebURL& url,

- const bool allow_credentials) override;

+ void prefetchDNS(const blink::WebString& hostname) override;

+ void preconnect(const blink::WebURL& url,

+ const bool allow_credentials) override;

private:

network_hints::RendererDnsPrefetch dns_prefetch_;