Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: components/autofill/content/renderer/autofill_agent.h

Issue 1361223003: Enforce marking "override" for functions overriding Blink in components/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/message_port/web_message_port_channel_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/content/renderer/autofill_agent.h
diff --git a/components/autofill/content/renderer/autofill_agent.h b/components/autofill/content/renderer/autofill_agent.h
index 64d374de12314152f1304d8f82979b6352018403..ab8653b31f9e6b7bb7d4a38947ece94ea890fbe0 100644
--- a/components/autofill/content/renderer/autofill_agent.h
+++ b/components/autofill/content/renderer/autofill_agent.h
@@ -51,7 +51,7 @@ class AutofillAgent : public content::RenderFrameObserver,
AutofillAgent(content::RenderFrame* render_frame,
PasswordAutofillAgent* password_autofill_manager,
PasswordGenerationAgent* password_generation_agent);
- virtual ~AutofillAgent();
+ ~AutofillAgent() override;
private:
// Functor used as a simplified comparison function for FormData. Only
@@ -126,22 +126,19 @@ class AutofillAgent : public content::RenderFrameObserver,
bool was_focused) override;
// blink::WebAutofillClient:
- virtual void textFieldDidEndEditing(
- const blink::WebInputElement& element);
- virtual void textFieldDidChange(
- const blink::WebFormControlElement& element);
- virtual void textFieldDidReceiveKeyDown(
+ void textFieldDidEndEditing(const blink::WebInputElement& element) override;
+ void textFieldDidChange(const blink::WebFormControlElement& element) override;
+ void textFieldDidReceiveKeyDown(
const blink::WebInputElement& element,
- const blink::WebKeyboardEvent& event);
- virtual void didRequestAutocomplete(
- const blink::WebFormElement& form);
- virtual void setIgnoreTextChanges(bool ignore);
- virtual void didAssociateFormControls(
- const blink::WebVector<blink::WebNode>& nodes);
- virtual void openTextDataListChooser(const blink::WebInputElement& element);
- virtual void dataListOptionsChanged(const blink::WebInputElement& element);
- virtual void firstUserGestureObserved();
- virtual void ajaxSucceeded();
+ const blink::WebKeyboardEvent& event) override;
+ void didRequestAutocomplete(const blink::WebFormElement& form) override;
+ void setIgnoreTextChanges(bool ignore) override;
+ void didAssociateFormControls(
+ const blink::WebVector<blink::WebNode>& nodes) override;
+ void openTextDataListChooser(const blink::WebInputElement& element) override;
+ void dataListOptionsChanged(const blink::WebInputElement& element) override;
+ void firstUserGestureObserved() override;
+ void ajaxSucceeded() override;
void OnFieldTypePredictionsAvailable(
const std::vector<FormDataPredictions>& forms);
« no previous file with comments | « no previous file | components/message_port/web_message_port_channel_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698