Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Side by Side Diff: components/autofill/content/renderer/autofill_agent.h

Issue 1361223003: Enforce marking "override" for functions overriding Blink in components/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/message_port/web_message_port_channel_impl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_AUTOFILL_CONTENT_RENDERER_AUTOFILL_AGENT_H_ 5 #ifndef COMPONENTS_AUTOFILL_CONTENT_RENDERER_AUTOFILL_AGENT_H_
6 #define COMPONENTS_AUTOFILL_CONTENT_RENDERER_AUTOFILL_AGENT_H_ 6 #define COMPONENTS_AUTOFILL_CONTENT_RENDERER_AUTOFILL_AGENT_H_
7 7
8 #include <set> 8 #include <set>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 class AutofillAgent : public content::RenderFrameObserver, 44 class AutofillAgent : public content::RenderFrameObserver,
45 public PageClickListener, 45 public PageClickListener,
46 public blink::WebAutofillClient { 46 public blink::WebAutofillClient {
47 public: 47 public:
48 // PasswordAutofillAgent is guaranteed to outlive AutofillAgent. 48 // PasswordAutofillAgent is guaranteed to outlive AutofillAgent.
49 // PasswordGenerationAgent may be NULL. If it is not, then it is also 49 // PasswordGenerationAgent may be NULL. If it is not, then it is also
50 // guaranteed to outlive AutofillAgent. 50 // guaranteed to outlive AutofillAgent.
51 AutofillAgent(content::RenderFrame* render_frame, 51 AutofillAgent(content::RenderFrame* render_frame,
52 PasswordAutofillAgent* password_autofill_manager, 52 PasswordAutofillAgent* password_autofill_manager,
53 PasswordGenerationAgent* password_generation_agent); 53 PasswordGenerationAgent* password_generation_agent);
54 virtual ~AutofillAgent(); 54 ~AutofillAgent() override;
55 55
56 private: 56 private:
57 // Functor used as a simplified comparison function for FormData. Only 57 // Functor used as a simplified comparison function for FormData. Only
58 // compares forms at a high level (notably name, origin, action). 58 // compares forms at a high level (notably name, origin, action).
59 struct FormDataCompare { 59 struct FormDataCompare {
60 bool operator()(const FormData& lhs, const FormData& rhs) const; 60 bool operator()(const FormData& lhs, const FormData& rhs) const;
61 }; 61 };
62 62
63 // Thunk class for RenderViewObserver methods that haven't yet been migrated 63 // Thunk class for RenderViewObserver methods that haven't yet been migrated
64 // to RenderFrameObserver. Should eventually be removed. 64 // to RenderFrameObserver. Should eventually be removed.
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
119 119
120 // Pass-through from LegacyAutofillAgent. This correlates with the 120 // Pass-through from LegacyAutofillAgent. This correlates with the
121 // RenderViewObserver method. 121 // RenderViewObserver method.
122 void FocusChangeComplete(); 122 void FocusChangeComplete();
123 123
124 // PageClickListener: 124 // PageClickListener:
125 void FormControlElementClicked(const blink::WebFormControlElement& element, 125 void FormControlElementClicked(const blink::WebFormControlElement& element,
126 bool was_focused) override; 126 bool was_focused) override;
127 127
128 // blink::WebAutofillClient: 128 // blink::WebAutofillClient:
129 virtual void textFieldDidEndEditing( 129 void textFieldDidEndEditing(const blink::WebInputElement& element) override;
130 const blink::WebInputElement& element); 130 void textFieldDidChange(const blink::WebFormControlElement& element) override;
131 virtual void textFieldDidChange( 131 void textFieldDidReceiveKeyDown(
132 const blink::WebFormControlElement& element);
133 virtual void textFieldDidReceiveKeyDown(
134 const blink::WebInputElement& element, 132 const blink::WebInputElement& element,
135 const blink::WebKeyboardEvent& event); 133 const blink::WebKeyboardEvent& event) override;
136 virtual void didRequestAutocomplete( 134 void didRequestAutocomplete(const blink::WebFormElement& form) override;
137 const blink::WebFormElement& form); 135 void setIgnoreTextChanges(bool ignore) override;
138 virtual void setIgnoreTextChanges(bool ignore); 136 void didAssociateFormControls(
139 virtual void didAssociateFormControls( 137 const blink::WebVector<blink::WebNode>& nodes) override;
140 const blink::WebVector<blink::WebNode>& nodes); 138 void openTextDataListChooser(const blink::WebInputElement& element) override;
141 virtual void openTextDataListChooser(const blink::WebInputElement& element); 139 void dataListOptionsChanged(const blink::WebInputElement& element) override;
142 virtual void dataListOptionsChanged(const blink::WebInputElement& element); 140 void firstUserGestureObserved() override;
143 virtual void firstUserGestureObserved(); 141 void ajaxSucceeded() override;
144 virtual void ajaxSucceeded();
145 142
146 void OnFieldTypePredictionsAvailable( 143 void OnFieldTypePredictionsAvailable(
147 const std::vector<FormDataPredictions>& forms); 144 const std::vector<FormDataPredictions>& forms);
148 void OnFillForm(int query_id, const FormData& form); 145 void OnFillForm(int query_id, const FormData& form);
149 void OnFirstUserGestureObservedInTab(); 146 void OnFirstUserGestureObservedInTab();
150 void OnPing(); 147 void OnPing();
151 void OnPreviewForm(int query_id, const FormData& form); 148 void OnPreviewForm(int query_id, const FormData& form);
152 149
153 // For external Autofill selection. 150 // For external Autofill selection.
154 void OnClearForm(); 151 void OnClearForm();
(...skipping 124 matching lines...) Expand 10 before | Expand all | Expand 10 after
279 bool is_generation_popup_possibly_visible_; 276 bool is_generation_popup_possibly_visible_;
280 277
281 base::WeakPtrFactory<AutofillAgent> weak_ptr_factory_; 278 base::WeakPtrFactory<AutofillAgent> weak_ptr_factory_;
282 279
283 DISALLOW_COPY_AND_ASSIGN(AutofillAgent); 280 DISALLOW_COPY_AND_ASSIGN(AutofillAgent);
284 }; 281 };
285 282
286 } // namespace autofill 283 } // namespace autofill
287 284
288 #endif // COMPONENTS_AUTOFILL_CONTENT_RENDERER_AUTOFILL_AGENT_H_ 285 #endif // COMPONENTS_AUTOFILL_CONTENT_RENDERER_AUTOFILL_AGENT_H_
OLDNEW
« no previous file with comments | « no previous file | components/message_port/web_message_port_channel_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698