Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: components/nacl/renderer/file_downloader.h

Issue 1361223003: Enforce marking "override" for functions overriding Blink in components/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/nacl/renderer/file_downloader.h
diff --git a/components/nacl/renderer/file_downloader.h b/components/nacl/renderer/file_downloader.h
index 02650d4e3a0e39c4ef48678f2ecf6e1aab5dab9c..a7d73389c72f7e48287b46f152763f514d8a3968 100644
--- a/components/nacl/renderer/file_downloader.h
+++ b/components/nacl/renderer/file_downloader.h
@@ -39,23 +39,23 @@ class FileDownloader : public blink::WebURLLoaderClient {
StatusCallback status_cb,
ProgressCallback progress_cb);
- virtual ~FileDownloader();
+ ~FileDownloader() override;
void Load(const blink::WebURLRequest& request);
private:
// WebURLLoaderClient implementation.
- virtual void didReceiveResponse(blink::WebURLLoader* loader,
- const blink::WebURLResponse& response);
- virtual void didReceiveData(blink::WebURLLoader* loader,
- const char* data,
- int data_length,
- int encoded_data_length);
- virtual void didFinishLoading(blink::WebURLLoader* loader,
- double finish_time,
- int64_t total_encoded_data_length);
- virtual void didFail(blink::WebURLLoader* loader,
- const blink::WebURLError& error);
+ void didReceiveResponse(blink::WebURLLoader* loader,
+ const blink::WebURLResponse& response) override;
+ void didReceiveData(blink::WebURLLoader* loader,
+ const char* data,
+ int data_length,
+ int encoded_data_length) override;
+ void didFinishLoading(blink::WebURLLoader* loader,
+ double finish_time,
+ int64_t total_encoded_data_length) override;
+ void didFail(blink::WebURLLoader* loader,
+ const blink::WebURLError& error) override;
scoped_ptr<blink::WebURLLoader> url_loader_;
base::File file_;
« no previous file with comments | « components/message_port/web_message_port_channel_impl.h ('k') | components/nacl/renderer/manifest_downloader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698