Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Unified Diff: components/password_manager/content/renderer/credential_manager_client_browsertest.cc

Issue 1361223003: Enforce marking "override" for functions overriding Blink in components/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/content/renderer/credential_manager_client_browsertest.cc
diff --git a/components/password_manager/content/renderer/credential_manager_client_browsertest.cc b/components/password_manager/content/renderer/credential_manager_client_browsertest.cc
index 70802c792416bca38f178c11a88d474ff7cde481..a6ab20e4495dcd5079480e8ad8a872a03c9a378a 100644
--- a/components/password_manager/content/renderer/credential_manager_client_browsertest.cc
+++ b/components/password_manager/content/renderer/credential_manager_client_browsertest.cc
@@ -105,11 +105,11 @@ class TestNotificationCallbacks
explicit TestNotificationCallbacks(CredentialManagerClientTest* test)
: test_(test) {}
- virtual ~TestNotificationCallbacks() {}
+ ~TestNotificationCallbacks() override {}
- virtual void onSuccess() { test_->set_callback_succeeded(true); }
+ void onSuccess() override { test_->set_callback_succeeded(true); }
- virtual void onError(blink::WebCredentialManagerError* reason) {
+ void onError(blink::WebCredentialManagerError* reason) override {
test_->set_callback_errored(true);
}
@@ -123,13 +123,13 @@ class TestRequestCallbacks
explicit TestRequestCallbacks(CredentialManagerClientTest* test)
: test_(test) {}
- virtual ~TestRequestCallbacks() {}
+ ~TestRequestCallbacks() override {}
- virtual void onSuccess(blink::WebCredential*) {
+ void onSuccess(blink::WebCredential*) override {
test_->set_callback_succeeded(true);
}
- virtual void onError(blink::WebCredentialManagerError* reason) {
+ void onError(blink::WebCredentialManagerError* reason) override {
test_->set_callback_errored(true);
}
« no previous file with comments | « components/password_manager/content/renderer/credential_manager_client.h ('k') | components/plugins/renderer/webview_plugin.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698