components/scheduler/child/webthread_impl_for_worker_scheduler_unittest.cc - Issue 1361223003: Enforce marking "override" for functions overriding Blink in components/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/scheduler/child/webthread_impl_for_worker_scheduler_unittest.cc

Issue 1361223003: Enforce marking "override" for functions overriding Blink in components/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/plugins/renderer/webview_plugin.h ('k') | components/scheduler/renderer/webthread_impl_for_renderer_scheduler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/scheduler/child/webthread_impl_for_worker_scheduler_unittest.cc

diff --git a/components/scheduler/child/webthread_impl_for_worker_scheduler_unittest.cc b/components/scheduler/child/webthread_impl_for_worker_scheduler_unittest.cc

index db4fd18726ed71e31877fd64aaff037b9ceb77b3..1f79c5c6884f69070bac928a608a8e479d97c254 100644

--- a/components/scheduler/child/webthread_impl_for_worker_scheduler_unittest.cc

+++ b/components/scheduler/child/webthread_impl_for_worker_scheduler_unittest.cc

@@ -23,7 +23,7 @@ class NopTask : public blink::WebTaskRunner::Task {

public:

~NopTask() override {}

- void run() {}

+ void run() override {}

};

class MockTask : public blink::WebTaskRunner::Task {