components/password_manager/content/renderer/credential_manager_client.h - Issue 1361223003: Enforce marking "override" for functions overriding Blink in components/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/renderer/credential_manager_client.h

Issue 1361223003: Enforce marking "override" for functions overriding Blink in components/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/network_hints/renderer/prescient_networking_dispatcher.h ('k') | components/password_manager/content/renderer/credential_manager_client_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/renderer/credential_manager_client.h

diff --git a/components/password_manager/content/renderer/credential_manager_client.h b/components/password_manager/content/renderer/credential_manager_client.h

index 3382c23ea88169578770be0367dc34adf1e8a5c7..a2f35c2c4eeae70417a7066b649495d661bb3ed0 100644

--- a/components/password_manager/content/renderer/credential_manager_client.h

+++ b/components/password_manager/content/renderer/credential_manager_client.h

@@ -63,13 +63,13 @@ class CredentialManagerClient : public blink::WebCredentialManagerClient,

blink::WebCredentialManagerError::ErrorType error_type);

// blink::WebCredentialManager:

- virtual void dispatchStore(

+ void dispatchStore(

const blink::WebCredential& credential,

- WebCredentialManagerClient::NotificationCallbacks* callbacks);

- virtual void dispatchRequireUserMediation(NotificationCallbacks* callbacks);

- virtual void dispatchGet(bool zero_click_only,

- const blink::WebVector<blink::WebURL>& federations,

- RequestCallbacks* callbacks);

+ WebCredentialManagerClient::NotificationCallbacks* callbacks) override;

+ void dispatchRequireUserMediation(NotificationCallbacks* callbacks) override;

+ void dispatchGet(bool zero_click_only,

+ const blink::WebVector<blink::WebURL>& federations,

+ RequestCallbacks* callbacks) override;

private:

typedef IDMap<blink::WebCredentialManagerClient::RequestCallbacks,