Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Side by Side Diff: components/password_manager/content/renderer/credential_manager_client.h

Issue 1361223003: Enforce marking "override" for functions overriding Blink in components/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_PASSWORD_MANAGER_CONTENT_RENDERER_CREDENTIAL_MANAGER_CLIENT_H _ 5 #ifndef COMPONENTS_PASSWORD_MANAGER_CONTENT_RENDERER_CREDENTIAL_MANAGER_CLIENT_H _
6 #define COMPONENTS_PASSWORD_MANAGER_CONTENT_RENDERER_CREDENTIAL_MANAGER_CLIENT_H _ 6 #define COMPONENTS_PASSWORD_MANAGER_CONTENT_RENDERER_CREDENTIAL_MANAGER_CLIENT_H _
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "base/id_map.h" 10 #include "base/id_map.h"
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 // Message handlers for messages from the browser process: 56 // Message handlers for messages from the browser process:
57 virtual void OnAcknowledgeStore(int request_id); 57 virtual void OnAcknowledgeStore(int request_id);
58 virtual void OnAcknowledgeRequireUserMediation(int request_id); 58 virtual void OnAcknowledgeRequireUserMediation(int request_id);
59 virtual void OnSendCredential(int request_id, 59 virtual void OnSendCredential(int request_id,
60 const CredentialInfo& credential_info); 60 const CredentialInfo& credential_info);
61 virtual void OnRejectCredentialRequest( 61 virtual void OnRejectCredentialRequest(
62 int request_id, 62 int request_id,
63 blink::WebCredentialManagerError::ErrorType error_type); 63 blink::WebCredentialManagerError::ErrorType error_type);
64 64
65 // blink::WebCredentialManager: 65 // blink::WebCredentialManager:
66 virtual void dispatchStore( 66 void dispatchStore(
67 const blink::WebCredential& credential, 67 const blink::WebCredential& credential,
68 WebCredentialManagerClient::NotificationCallbacks* callbacks); 68 WebCredentialManagerClient::NotificationCallbacks* callbacks) override;
69 virtual void dispatchRequireUserMediation(NotificationCallbacks* callbacks); 69 void dispatchRequireUserMediation(NotificationCallbacks* callbacks) override;
70 virtual void dispatchGet(bool zero_click_only, 70 void dispatchGet(bool zero_click_only,
71 const blink::WebVector<blink::WebURL>& federations, 71 const blink::WebVector<blink::WebURL>& federations,
72 RequestCallbacks* callbacks); 72 RequestCallbacks* callbacks) override;
73 73
74 private: 74 private:
75 typedef IDMap<blink::WebCredentialManagerClient::RequestCallbacks, 75 typedef IDMap<blink::WebCredentialManagerClient::RequestCallbacks,
76 IDMapOwnPointer> RequestCallbacksMap; 76 IDMapOwnPointer> RequestCallbacksMap;
77 typedef IDMap<blink::WebCredentialManagerClient::NotificationCallbacks, 77 typedef IDMap<blink::WebCredentialManagerClient::NotificationCallbacks,
78 IDMapOwnPointer> NotificationCallbacksMap; 78 IDMapOwnPointer> NotificationCallbacksMap;
79 79
80 void RespondToNotificationCallback(int request_id, 80 void RespondToNotificationCallback(int request_id,
81 NotificationCallbacksMap* map); 81 NotificationCallbacksMap* map);
82 82
83 // Track the various blink::WebCredentialManagerClient::*Callbacks objects 83 // Track the various blink::WebCredentialManagerClient::*Callbacks objects
84 // generated from Blink. This class takes ownership of these objects. 84 // generated from Blink. This class takes ownership of these objects.
85 NotificationCallbacksMap failed_sign_in_callbacks_; 85 NotificationCallbacksMap failed_sign_in_callbacks_;
86 NotificationCallbacksMap store_callbacks_; 86 NotificationCallbacksMap store_callbacks_;
87 NotificationCallbacksMap require_user_mediation_callbacks_; 87 NotificationCallbacksMap require_user_mediation_callbacks_;
88 RequestCallbacksMap get_callbacks_; 88 RequestCallbacksMap get_callbacks_;
89 89
90 DISALLOW_COPY_AND_ASSIGN(CredentialManagerClient); 90 DISALLOW_COPY_AND_ASSIGN(CredentialManagerClient);
91 }; 91 };
92 92
93 } // namespace password_manager 93 } // namespace password_manager
94 94
95 #endif // COMPONENTS_PASSWORD_MANAGER_CONTENT_RENDERER_CREDENTIAL_MANAGER_CLIEN T_H_ 95 #endif // COMPONENTS_PASSWORD_MANAGER_CONTENT_RENDERER_CREDENTIAL_MANAGER_CLIEN T_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698