Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1771)

Issue 1358513003: Use correct IntToString variants in //chrome (Closed)

Created:
5 years, 3 months ago by Adam Rice
Modified:
5 years, 3 months ago
Reviewers:
Lei Zhang
CC:
bondd+autofillwatch_chromium.org, cbentzel+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, devtools-reviews_chromium.org, estade+watch_chromium.org, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, grt+watch_chromium.org, jdonnelly+autofillwatch_chromium.org, kinuko+fileapi, maxbogue+watch_chromium.org, mcasas+watch_chromium.org, nhiroki, pfeldman, plaree+watch_chromium.org, posciak+watch_chromium.org, pvalenzuela+watch_chromium.org, rouslan+autofill_chromium.org, samuong+watch_chromium.org, shishir+watch_chromium.org, James Su, tfarina, tim+watch_chromium.org, tzik, yurys, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use correct IntToString variants in //chrome Using IntToString() with a type larger than an int can lead to unexpected truncation. Similarly, using it with an unsigned value can lead to undesirable results. Use the appropriate IntToString() variant for the type of the integer being converted. BUG=505479 TEST=compiled Committed: https://crrev.com/95212c13d90f2d8f45c5c48be6eb0da1832ec34e Cr-Commit-Position: refs/heads/master@{#349846}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -97 lines) Patch
M chrome/browser/apps/ephemeral_app_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/bookmark_provider_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/autocomplete/search_provider_unittest.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/devtools/device/tcp_device_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/devtools/remote_debugging_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/automation/automation_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/desktop_capture/desktop_capture_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/chrome_url_request_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/content_capabilities_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/error_console/error_console_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_messages_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_storage_monitor.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/importer/profile_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/internal_auth.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/local_discovery/privet_http_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/media/webrtc_logging_handler_host.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profile_resetter/automatic_profile_resetter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_window.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/shell_integration_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/easy_unlock_screenlock_state_handler_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/test/integration/performance/sync_timing_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/leveldb_wrapper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/libgtk2ui/select_file_dialog_impl_kde.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/media_galleries_dialog_views_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/new_task_manager_view.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/about_ui.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/plugins/plugins_handler.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/content_scripts_handler.cc View 8 chunks +15 lines, -25 lines 0 comments Download
M chrome/common/net/x509_certificate_model_nss.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/test/chromedriver/chrome/device_manager.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/test/chromedriver/chrome_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/third_party/mozilla_security_manager/nsNSSCertHelper.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Adam Rice
thestig, can you review this for all of //chrome, or should I assign more specific ...
5 years, 3 months ago (2015-09-18 21:43:08 UTC) #2
Lei Zhang
I only spot checked the files with +N/-N changes, and checked all files with +M/-N ...
5 years, 3 months ago (2015-09-18 23:28:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1358513003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1358513003/1
5 years, 3 months ago (2015-09-19 03:42:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-19 04:10:14 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-19 04:10:59 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/95212c13d90f2d8f45c5c48be6eb0da1832ec34e
Cr-Commit-Position: refs/heads/master@{#349846}

Powered by Google App Engine
This is Rietveld 408576698