chrome/browser/devtools/remote_debugging_server.cc - Issue 1358513003: Use correct IntToString variants in //chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/remote_debugging_server.cc

Issue 1358513003: Use correct IntToString variants in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/devtools/remote_debugging_server.cc

diff --git a/chrome/browser/devtools/remote_debugging_server.cc b/chrome/browser/devtools/remote_debugging_server.cc

index 49c8f588f178679608d871a9dfde878969df7773..e7306d12936c1d8575eb2624de93d4789866373c 100644

--- a/chrome/browser/devtools/remote_debugging_server.cc

+++ b/chrome/browser/devtools/remote_debugging_server.cc

@@ -60,7 +60,7 @@ class TCPServerSocketFactory

if (last_tethering_port_ == kMaxTetheringPort)

last_tethering_port_ = kMinTetheringPort;

uint16 port = ++last_tethering_port_;

- *name = base::IntToString(port);

+ *name = base::UintToString(port);

scoped_ptr<net::TCPServerSocket> socket(

new net::TCPServerSocket(nullptr, net::NetLog::Source()));

if (socket->ListenWithAddressAndPort("127.0.0.1", port, kBackLog) !=