chrome/test/chromedriver/chrome_launcher.cc - Issue 1358513003: Use correct IntToString variants in //chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome_launcher.cc

Issue 1358513003: Use correct IntToString variants in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/chrome_launcher.cc

diff --git a/chrome/test/chromedriver/chrome_launcher.cc b/chrome/test/chromedriver/chrome_launcher.cc

index be302dc2a2ac5e7f074d27179092456b1c1b7a14..57bec2613fbcf9fd78e9aaa83b33122448ce5bf1 100644

--- a/chrome/test/chromedriver/chrome_launcher.cc

+++ b/chrome/test/chromedriver/chrome_launcher.cc

@@ -135,7 +135,7 @@ Status PrepareCommandLine(uint16 port,

switches.SetUnparsedSwitch(common_switch);

for (const auto& desktop_switch : kDesktopSwitches)

switches.SetUnparsedSwitch(desktop_switch);

- switches.SetSwitch("remote-debugging-port", base::IntToString(port));

+ switches.SetSwitch("remote-debugging-port", base::UintToString(port));

for (const auto& excluded_switch : capabilities.exclude_switches) {

switches.RemoveSwitch(excluded_switch);

}