chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc - Issue 1358513003: Use correct IntToString variants in //chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc

Issue 1358513003: Use correct IntToString variants in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/net/x509_certificate_model_nss.cc ('k') | chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc

diff --git a/chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc b/chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc

index 082cf0db8759732d8753fe40b552dc80de52b7cb..a3c3b4b1ad78489a681fa305b29faafdeaddf6ef 100644

--- a/chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc

+++ b/chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc

@@ -280,7 +280,7 @@ IN_PROC_BROWSER_TEST_F(PhishingClassifierDelegateTest, Navigation) {

// Test an initial load. We expect classification to happen normally.

EXPECT_CALL(*classifier_, CancelPendingClassification()).Times(2);

- std::string port = base::IntToString(embedded_test_server_->port());

+ std::string port = base::UintToString(embedded_test_server_->port());

std::string html = "<html><body><iframe src=\"http://sub1.com:";

html += port;

html += "/\"></iframe></body></html>";

@@ -545,7 +545,7 @@ IN_PROC_BROWSER_TEST_F(PhishingClassifierDelegateTest,

Mock::VerifyAndClearExpectations(classifier_);

std::string url_str = "http://host4.com:";

- url_str += base::IntToString(embedded_test_server_->port());

+ url_str += base::UintToString(embedded_test_server_->port());

url_str += "/redir";

OnStartPhishingDetection(GURL(url_str));

page_text = ASCIIToUTF16("123");