chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc - Issue 1358513003: Use correct IntToString variants in //chrome

Unified Diff: chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc

Issue 1358513003: Use correct IntToString variants in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc ('k') | chrome/test/chromedriver/chrome/device_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc

diff --git a/chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc b/chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc

index 6719fe8fa0a7cad8f7f3b0513311237491a1a17e..b2645eb598b0b560940923c2f87a3c8c3ee642bc 100644

--- a/chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc

+++ b/chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc

@@ -205,7 +205,7 @@ IN_PROC_BROWSER_TEST_F(PhishingDOMFeatureExtractorTest, FormFeatures) {

std::string("http://other.com/"));

expected_features.AddBooleanFeature(features::kPageActionURL +

std::string("http://host.com:") +

- base::IntToString(embedded_test_server_->port()) +

+ base::UintToString(embedded_test_server_->port()) +

std::string("/query"));

FeatureMap features;

@@ -289,7 +289,7 @@ IN_PROC_BROWSER_TEST_F(PhishingDOMFeatureExtractorTest, LinkFeatures) {

// The PhishingDOMFeatureExtractor depends on URLs being domains and not IPs,

// so use a domain.

std::string url_str = "https://host.com:";

- url_str += base::IntToString(https_server.host_port_pair().port());

+ url_str += base::UintToString(https_server.host_port_pair().port());

url_str += "/files/safe_browsing/secure_link_features.html";

ui_test_utils::NavigateToURL(browser(), GURL(url_str));

@@ -340,7 +340,7 @@ IN_PROC_BROWSER_TEST_F(PhishingDOMFeatureExtractorTest,

// The PhishingDOMFeatureExtractor depends on URLs being domains and not IPs,

// so use a domain.

std::string url_str = "https://host.com:";

- url_str += base::IntToString(https_server.host_port_pair().port());

+ url_str += base::UintToString(https_server.host_port_pair().port());

url_str += "/files/safe_browsing/secure_script_and_image.html";

ui_test_utils::NavigateToURL(browser(), GURL(url_str));

@@ -360,7 +360,7 @@ IN_PROC_BROWSER_TEST_F(PhishingDOMFeatureExtractorTest, SubFrames) {

// Test that features are aggregated across all frames.

- std::string port = base::IntToString(embedded_test_server_->port());

+ std::string port = base::UintToString(embedded_test_server_->port());

responses_[GetURL("host2.com", "").spec()] =

"<html><head><script></script><body>"

"<form action=\"http://host4.com/\"><input type=checkbox></form>"

@@ -474,7 +474,7 @@ IN_PROC_BROWSER_TEST_F(PhishingDOMFeatureExtractorTest, MAYBE_Continuation) {

expected_features.AddRealFeature(features::kPageActionOtherDomainFreq, 0.5);

expected_features.AddBooleanFeature(features::kPageActionURL +

std::string("http://host.com:") +

- base::IntToString(embedded_test_server_->port()) +

+ base::UintToString(embedded_test_server_->port()) +

std::string("/ondomain"));

expected_features.AddBooleanFeature(features::kPageActionURL +

std::string("http://host2.com/"));