chrome/browser/signin/easy_unlock_screenlock_state_handler_unittest.cc - Issue 1358513003: Use correct IntToString variants in //chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/signin/easy_unlock_screenlock_state_handler_unittest.cc

Issue 1358513003: Use correct IntToString variants in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/shell_integration_linux.cc ('k') | chrome/browser/sync/test/integration/performance/sync_timing_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/signin/easy_unlock_screenlock_state_handler_unittest.cc

diff --git a/chrome/browser/signin/easy_unlock_screenlock_state_handler_unittest.cc b/chrome/browser/signin/easy_unlock_screenlock_state_handler_unittest.cc

index c89d357627c9fc2067e0712cfe9d37ef413fdbb0..0e1c7e04d2fdfa8c386b7164e4f6923aae6e705a 100644

--- a/chrome/browser/signin/easy_unlock_screenlock_state_handler_unittest.cc

+++ b/chrome/browser/signin/easy_unlock_screenlock_state_handler_unittest.cc

@@ -353,7 +353,7 @@ TEST_F(EasyUnlockScreenlockStateHandlerTest, StatesWithLockedIcon) {

states.push_back(ScreenlockState::PHONE_LOCKED);

for (size_t i = 0; i < states.size(); ++i) {

- SCOPED_TRACE(base::IntToString(i));

+ SCOPED_TRACE(base::SizeTToString(i));

state_handler_->ChangeState(states[i]);

EXPECT_TRUE(state_handler_->IsActive());

@@ -469,7 +469,7 @@ TEST_F(EasyUnlockScreenlockStateHandlerTest,

states.push_back(ScreenlockState::AUTHENTICATED);

for (size_t i = 0; i < states.size(); ++i) {

- SCOPED_TRACE(base::IntToString(i));

+ SCOPED_TRACE(base::SizeTToString(i));

state_handler_->ChangeState(states[i]);

ASSERT_TRUE(lock_handler_->HasCustomIcon());

EXPECT_FALSE(lock_handler_->CustomIconHardlocksOnClick());

@@ -480,7 +480,7 @@ TEST_F(EasyUnlockScreenlockStateHandlerTest,

proximity_auth::ScreenlockBridge::Get()->SetLockHandler(lock_handler_.get());

for (size_t i = 0; i < states.size(); ++i) {

- SCOPED_TRACE(base::IntToString(i));

+ SCOPED_TRACE(base::SizeTToString(i));

state_handler_->ChangeState(states[i]);

ASSERT_TRUE(lock_handler_->HasCustomIcon());

EXPECT_TRUE(lock_handler_->CustomIconHardlocksOnClick());