chrome/browser/devtools/device/tcp_device_provider.cc - Issue 1358513003: Use correct IntToString variants in //chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/device/tcp_device_provider.cc

Issue 1358513003: Use correct IntToString variants in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/devtools/device/tcp_device_provider.cc

diff --git a/chrome/browser/devtools/device/tcp_device_provider.cc b/chrome/browser/devtools/device/tcp_device_provider.cc

index b48cb6876efdd86507432dc3d35234283b38cd7d..381f4c1a62994f2d4d8e59dad9b5bb64f6239a49 100644

--- a/chrome/browser/devtools/device/tcp_device_provider.cc

+++ b/chrome/browser/devtools/device/tcp_device_provider.cc

@@ -97,7 +97,7 @@ void TCPDeviceProvider::QueryDeviceInfo(const std::string& serial,

if (serial != target.host())

continue;

AndroidDeviceManager::BrowserInfo browser_info;

- browser_info.socket_name = base::IntToString(target.port());

+ browser_info.socket_name = base::UintToString(target.port());

browser_info.display_name = kBrowserName;

browser_info.type = AndroidDeviceManager::BrowserInfo::kTypeChrome;