Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Side by Side Diff: chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer.cc

Issue 1358513003: Use correct IntToString variants in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/profiles/profile_window.cc ('k') | chrome/browser/shell_integration_linux.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/safe_browsing/incident_reporting/binary_integrity_analy zer.h" 5 #include "chrome/browser/safe_browsing/incident_reporting/binary_integrity_analy zer.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/callback.h" 10 #include "base/callback.h"
(...skipping 13 matching lines...) Expand all
24 namespace safe_browsing { 24 namespace safe_browsing {
25 25
26 namespace { 26 namespace {
27 27
28 void RecordSignatureVerificationTime(size_t file_index, 28 void RecordSignatureVerificationTime(size_t file_index,
29 const base::TimeDelta& verification_time) { 29 const base::TimeDelta& verification_time) {
30 static const char kHistogramName[] = "SBIRS.VerifyBinaryIntegrity."; 30 static const char kHistogramName[] = "SBIRS.VerifyBinaryIntegrity.";
31 31
32 base::HistogramBase* signature_verification_time_histogram = 32 base::HistogramBase* signature_verification_time_histogram =
33 base::Histogram::FactoryTimeGet( 33 base::Histogram::FactoryTimeGet(
34 std::string(kHistogramName) + base::IntToString(file_index), 34 std::string(kHistogramName) + base::SizeTToString(file_index),
35 base::TimeDelta::FromMilliseconds(1), 35 base::TimeDelta::FromMilliseconds(1),
36 base::TimeDelta::FromSeconds(20), 36 base::TimeDelta::FromSeconds(20),
37 50, 37 50,
38 base::Histogram::kUmaTargetedHistogramFlag); 38 base::Histogram::kUmaTargetedHistogramFlag);
39 39
40 signature_verification_time_histogram->AddTime(verification_time); 40 signature_verification_time_histogram->AddTime(verification_time);
41 } 41 }
42 42
43 } // namespace 43 } // namespace
44 44
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 } 85 }
86 } 86 }
87 87
88 #if !defined(OS_WIN) 88 #if !defined(OS_WIN)
89 std::vector<base::FilePath> GetCriticalBinariesPath() { 89 std::vector<base::FilePath> GetCriticalBinariesPath() {
90 return std::vector<base::FilePath>(); 90 return std::vector<base::FilePath>();
91 } 91 }
92 #endif // !defined(OS_WIN) 92 #endif // !defined(OS_WIN)
93 93
94 } // namespace safe_browsing 94 } // namespace safe_browsing
OLDNEW
« no previous file with comments | « chrome/browser/profiles/profile_window.cc ('k') | chrome/browser/shell_integration_linux.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698