chrome/browser/extensions/extension_messages_apitest.cc - Issue 1358513003: Use correct IntToString variants in //chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_messages_apitest.cc

Issue 1358513003: Use correct IntToString variants in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_messages_apitest.cc

diff --git a/chrome/browser/extensions/extension_messages_apitest.cc b/chrome/browser/extensions/extension_messages_apitest.cc

index f62159b374054e378d7e2d23704e4712a96085b9..e20342546fa672289ef8e4a7ed850b4a8fc45fe5 100644

--- a/chrome/browser/extensions/extension_messages_apitest.cc

+++ b/chrome/browser/extensions/extension_messages_apitest.cc

@@ -278,7 +278,7 @@ class ExternallyConnectableMessagingTest : public ExtensionApiTest {

}

GURL GetURLForPath(const std::string& host, const std::string& path) {

- std::string port = base::IntToString(embedded_test_server()->port());

+ std::string port = base::UintToString(embedded_test_server()->port());

GURL::Replacements replacements;

replacements.SetHostStr(host);

replacements.SetPortStr(port);