Remove base's implicit_cast.

Remove base's implicit_cast.

There's no momentum on making this a thing in the C++ standard. We
should have less magic that is non-standard in base.

R=ricea@chromium.org, thakis@chromium.org, vmpstr
BUG=529769
Committed: https://crrev.com/a5f0d96bc4f40971fc82e0b2255e27056d4621d1
Cr-Commit-Position: refs/heads/master@{#348978}

[danakj, 2015-09-11 20:44:21]

https://codereview.chromium.org/1340683002/diff/1/base/android/scoped_java_ref.h
File base/android/scoped_java_ref.h (left):

https://codereview.chromium.org/1340683002/diff/1/base/android/scoped_java_re...
base/android/scoped_java_ref.h:181: implicit_cast<T>(obj);  // Ensure U is
assignable to T
This says "assignable" but implicit_cast does a conversion not an assignment, so
I think this means "convertible". Thus using that check instead.

https://codereview.chromium.org/1340683002/diff/1/base/memory/scoped_ptr.h
File base/memory/scoped_ptr.h (right):

https://codereview.chromium.org/1340683002/diff/1/base/memory/scoped_ptr.h#ne...
base/memory/scoped_ptr.h:470: //   NOT use static_cast<Base*>() to upcast the
static type of the array.
I'm not sure this is really the right way to say things still.. please confirm.

https://codereview.chromium.org/1340683002/diff/1/chrome/browser/apps/app_shi...
File chrome/browser/apps/app_shim/app_shim_host_mac_unittest.cc (right):

https://codereview.chromium.org/1340683002/diff/1/chrome/browser/apps/app_shi...
chrome/browser/apps/app_shim/app_shim_host_mac_unittest.cc:81:
static_cast<IPC::Listener*>(host_.release())->OnChannelError();
These were probably the most valid use of implicit_cast we had.

https://codereview.chromium.org/1340683002/diff/1/chrome/browser/ui/views/app...
File chrome/browser/ui/views/apps/chrome_native_app_window_views_win.cc (right):

https://codereview.chromium.org/1340683002/diff/1/chrome/browser/ui/views/app...
chrome/browser/ui/views/apps/chrome_native_app_window_views_win.cc:60:
views::Widget* widget = GetWidget();
I don't see GetWidget becoming non-public between WidgetDelegate and this class,
we'll see.

[Nico, 2015-09-11 20:53:55]

lgtm (thanks!), but a few questions:

https://codereview.chromium.org/1340683002/diff/1/base/memory/scoped_ptr.h
File base/memory/scoped_ptr.h (right):

https://codereview.chromium.org/1340683002/diff/1/base/memory/scoped_ptr.h#ne...
base/memory/scoped_ptr.h:470: //   NOT use static_cast<Base*>() to upcast the
static type of the array.
On 2015/09/11 20:44:20, danakj wrote:
> I'm not sure this is really the right way to say things still.. please
confirm.

This probably needs const_cast?

https://codereview.chromium.org/1340683002/diff/1/chrome/browser/apps/app_shi...
File chrome/browser/apps/app_shim/app_shim_host_mac_unittest.cc (right):

https://codereview.chromium.org/1340683002/diff/1/chrome/browser/apps/app_shi...
chrome/browser/apps/app_shim/app_shim_host_mac_unittest.cc:81:
static_cast<IPC::Listener*>(host_.release())->OnChannelError();
On 2015/09/11 20:44:20, danakj wrote:
> These were probably the most valid use of implicit_cast we had.

Why is a cast needed here at all?

https://codereview.chromium.org/1340683002/diff/1/chrome/browser/ui/views/app...
File chrome/browser/ui/views/apps/chrome_native_app_window_views_mac.mm (right):

https://codereview.chromium.org/1340683002/diff/1/chrome/browser/ui/views/app...
chrome/browser/ui/views/apps/chrome_native_app_window_views_mac.mm:41:
object:static_cast<ui::BaseWindow*>(nativeAppWindow)
(same question here)

[danakj, 2015-09-11 20:56:16]

https://codereview.chromium.org/1340683002/diff/1/chrome/browser/apps/app_shi...
File chrome/browser/apps/app_shim/app_shim_host_mac_unittest.cc (right):

https://codereview.chromium.org/1340683002/diff/1/chrome/browser/apps/app_shi...
chrome/browser/apps/app_shim/app_shim_host_mac_unittest.cc:81:
static_cast<IPC::Listener*>(host_.release())->OnChannelError();
On 2015/09/11 20:53:55, Nico wrote:
> On 2015/09/11 20:44:20, danakj wrote:
> > These were probably the most valid use of implicit_cast we had.
> 
> Why is a cast needed here at all?

Here the IPC::Listener interface is overridden by an ancestor class that makes
it protected/private. Ditto below for respective classes.

https://codereview.chromium.org/1340683002/diff/1/chrome/browser/ui/views/app...
File chrome/browser/ui/views/apps/chrome_native_app_window_views_mac.mm (right):

https://codereview.chromium.org/1340683002/diff/1/chrome/browser/ui/views/app...
chrome/browser/ui/views/apps/chrome_native_app_window_views_mac.mm:41:
object:static_cast<ui::BaseWindow*>(nativeAppWindow)
On 2015/09/11 20:53:55, Nico wrote:
> (same question here)

ditto, the NativeAppWindowViews class makes this GetNativeWindow method
protected. (This has a bad smell to me but ya)

[vmpstr, 2015-09-11 21:00:49]

There's a bunch of places that have potential truncation I think. It might help
to fix them where you can see them so that

# TODO(jschuh): crbug.com/167187 fix size_t to int truncations.

is easier to fix.

https://codereview.chromium.org/1340683002/diff/1/components/history/core/bro...
File components/history/core/browser/history_backend.cc (right):

https://codereview.chromium.org/1340683002/diff/1/components/history/core/bro...
components/history/core/browser/history_backend.cc:1370: if (result_count &&
static_cast<int>(data.size()) > result_count)
This should probably be either a saturated_cast or a checked_cast (or even
better QueryFilteredURLs might take a size_t for result_count, but I'm not sure
about what this code does and how set the signature is).

https://codereview.chromium.org/1340683002/diff/1/content/browser/cache_stora...
File content/browser/cache_storage/cache_storage.cc (right):

https://codereview.chromium.org/1340683002/diff/1/content/browser/cache_stora...
content/browser/cache_storage/cache_storage.cc:279: if (bytes_written !=
static_cast<int>(data.size())) {
Same here, maybe?

[danakj, 2015-09-11 21:20:28]

Thanks! PTAL

https://codereview.chromium.org/1340683002/diff/1/base/memory/scoped_ptr.h
File base/memory/scoped_ptr.h (right):

https://codereview.chromium.org/1340683002/diff/1/base/memory/scoped_ptr.h#ne...
base/memory/scoped_ptr.h:470: //   NOT use static_cast<Base*>() to upcast the
static type of the array.
On 2015/09/11 20:53:54, Nico wrote:
> On 2015/09/11 20:44:20, danakj wrote:
> > I'm not sure this is really the right way to say things still.. please
> confirm.
> 
> This probably needs const_cast?

Ah yah, ok changed both to const_cast in the comment.

https://codereview.chromium.org/1340683002/diff/1/components/history/core/bro...
File components/history/core/browser/history_backend.cc (right):

https://codereview.chromium.org/1340683002/diff/1/components/history/core/bro...
components/history/core/browser/history_backend.cc:1370: if (result_count &&
static_cast<int>(data.size()) > result_count)
On 2015/09/11 21:00:49, vmpstr wrote:
> This should probably be either a saturated_cast or a checked_cast (or even
> better QueryFilteredURLs might take a size_t for result_count, but I'm not
sure
> about what this code does and how set the signature is).

Changing the type seems a bit tricky, it does all the way through the history
stuff, down to places like
https://code.google.com/p/chromium/codesearch#chromium/src/components/history...

Where it clearly expects the range to be within an integer, so I don't want to
change assumptions naively.

I think the intent here is to have a positive integer-ranged value. So we can
cast the ints to size_t for the purpose of comparison and not get weird
truncation issues, and also make life easier for that TODO.

https://codereview.chromium.org/1340683002/diff/1/content/browser/cache_stora...
File content/browser/cache_storage/cache_storage.cc (right):

https://codereview.chromium.org/1340683002/diff/1/content/browser/cache_stora...
content/browser/cache_storage/cache_storage.cc:279: if (bytes_written !=
static_cast<int>(data.size())) {
On 2015/09/11 21:00:49, vmpstr wrote:
> Same here, maybe?

Here we pass data.size() to base::WriteFile which takes an int. So that's a
silent truncation right now.

So the assumption here is that data will be within positive integer size. I
think checked_cast makes sense here.

[danakj, 2015-09-11 21:31:04]

danakj@chromium.org changed reviewers:
+ jsbell@chromium.org, rsleevi@chromium.org, sky@chromium.org

[danakj, 2015-09-11 21:31:05]

+sky for components/history and ui/ OWNERS
+jsbell for content/browser/cache_storage OWNERS
+rsleevi for net/ OWNERS

[vmpstr, 2015-09-11 21:31:15]

vmpstr@chromium.org changed reviewers:
- jsbell@chromium.org, rsleevi@chromium.org, sky@chromium.org

[vmpstr, 2015-09-11 21:31:16]

There are a few more, but I think some are ok like
static_cast<int>(sizeof(foo))
Your call which ones to change which ones to keep.

lgtm otherwise

https://codereview.chromium.org/1340683002/diff/60001/net/disk_cache/simple/s...
File net/disk_cache/simple/simple_index_file.cc (right):

https://codereview.chromium.org/1340683002/diff/60001/net/disk_cache/simple/s...
net/disk_cache/simple/simple_index_file.cc:80: if (bytes_written !=
static_cast<int>(pickle->size())) {
checked_cast?

https://codereview.chromium.org/1340683002/diff/60001/net/disk_cache/simple/s...
File net/disk_cache/simple/simple_synchronous_entry.cc (right):

https://codereview.chromium.org/1340683002/diff/60001/net/disk_cache/simple/s...
net/disk_cache/simple/simple_synchronous_entry.cc:942: if (key_read_result !=
static_cast<int>(header.key_length)) {
Here as well (and throughout this file).

https://codereview.chromium.org/1340683002/diff/60001/ui/base/page_transition...
File ui/base/page_transition_types.cc (right):

https://codereview.chromium.org/1340683002/diff/60001/ui/base/page_transition...
ui/base/page_transition_types.cc:16: return
static_cast<int>(PageTransitionStripQualifier(lhs)) ==
This looks like an enum-to-same-enum comparison, so I don't think you need a
cast?

https://codereview.chromium.org/1340683002/diff/80001/ui/views/style/mac/dial...
File ui/views/style/mac/dialog_button_border_mac_unittest.cc (right):

https://codereview.chromium.org/1340683002/diff/80001/ui/views/style/mac/dial...
ui/views/style/mac/dialog_button_border_mac_unittest.cc:66:
EXPECT_EQ(static_cast<SkColor>(SK_ColorTRANSPARENT), initial_pixel);
o_O I'm guessing SK_ColorTRANSPARENT is signed and SkColor is unsigned? :)

[danakj, 2015-09-11 21:31:52]

On 2015/09/11 21:00:49, vmpstr wrote:
> There's a bunch of places that have potential truncation I think. It might
help
> to fix them where you can see them so that
> 
> # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
> 
> is easier to fix.

I also used checked_casts around converting size_t to int around
base::File::Write/Read in net. And I think I can remove the cast entirely in
ui/base/. Woo.

[danakj, 2015-09-11 21:33:30]

https://codereview.chromium.org/1340683002/diff/60001/net/disk_cache/simple/s...
File net/disk_cache/simple/simple_index_file.cc (right):

https://codereview.chromium.org/1340683002/diff/60001/net/disk_cache/simple/s...
net/disk_cache/simple/simple_index_file.cc:80: if (bytes_written !=
static_cast<int>(pickle->size())) {
On 2015/09/11 21:31:16, vmpstr wrote:
> checked_cast?

Yep

https://codereview.chromium.org/1340683002/diff/60001/net/disk_cache/simple/s...
File net/disk_cache/simple/simple_synchronous_entry.cc (right):

https://codereview.chromium.org/1340683002/diff/60001/net/disk_cache/simple/s...
net/disk_cache/simple/simple_synchronous_entry.cc:942: if (key_read_result !=
static_cast<int>(header.key_length)) {
On 2015/09/11 21:31:16, vmpstr wrote:
> Here as well (and throughout this file).

Yaya

https://codereview.chromium.org/1340683002/diff/60001/ui/base/page_transition...
File ui/base/page_transition_types.cc (right):

https://codereview.chromium.org/1340683002/diff/60001/ui/base/page_transition...
ui/base/page_transition_types.cc:16: return
static_cast<int>(PageTransitionStripQualifier(lhs)) ==
On 2015/09/11 21:31:16, vmpstr wrote:
> This looks like an enum-to-same-enum comparison, so I don't think you need a
> cast? 

Ya I agree.

https://codereview.chromium.org/1340683002/diff/80001/ui/views/style/mac/dial...
File ui/views/style/mac/dialog_button_border_mac_unittest.cc (right):

https://codereview.chromium.org/1340683002/diff/80001/ui/views/style/mac/dial...
ui/views/style/mac/dialog_button_border_mac_unittest.cc:66:
EXPECT_EQ(static_cast<SkColor>(SK_ColorTRANSPARENT), initial_pixel);
On 2015/09/11 21:31:16, vmpstr wrote:
> o_O I'm guessing SK_ColorTRANSPARENT is signed and SkColor is unsigned? :)

I think so. SkColor is uint32_t. The TRANSPARENT is 0x0, which is probably
signed by default? (I maybe wish the #define did this cast.)

[vmpstr, 2015-09-11 21:34:36]

https://codereview.chromium.org/1340683002/diff/80001/ui/views/style/mac/dial...
File ui/views/style/mac/dialog_button_border_mac_unittest.cc (right):

https://codereview.chromium.org/1340683002/diff/80001/ui/views/style/mac/dial...
ui/views/style/mac/dialog_button_border_mac_unittest.cc:66:
EXPECT_EQ(static_cast<SkColor>(SK_ColorTRANSPARENT), initial_pixel);
On 2015/09/11 21:33:30, danakj wrote:
> On 2015/09/11 21:31:16, vmpstr wrote:
> > o_O I'm guessing SK_ColorTRANSPARENT is signed and SkColor is unsigned? :)
> 
> I think so. SkColor is uint32_t. The TRANSPARENT is 0x0, which is probably
> signed by default? (I maybe wish the #define did this cast.)

Yeah, I wish for the same thing.

[Ryan Sleevi, 2015-09-11 21:34:44]

rsleevi@chromium.org changed reviewers:
+ rsleevi@chromium.org

[Ryan Sleevi, 2015-09-11 21:34:44]

net LGTM

[sky, 2015-09-11 21:58:58]

sky@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2015-09-11 21:58:58]

LGTM

[jsbell, 2015-09-11 22:13:08]

jsbell@chromium.org changed reviewers:
+ jsbell@chromium.org

[jsbell, 2015-09-11 22:13:08]

content/browser/cache_storage lgtm

[boliu, 2015-09-11 23:12:24]

boliu@chromium.org changed reviewers:
+ boliu@chromium.org

[boliu, 2015-09-11 23:12:24]

android_webview lgtm

[danakj, 2015-09-11 23:12:37]

danakj@chromium.org changed reviewers:
- boliu@chromium.org

[danakj, 2015-09-11 23:12:38]

Aw, crash pad is using this from base apparently:
../../third_party/crashpad/crashpad/util/file/file_writer.cc:76:36:error: use of
undeclared identifier 'implicit_cast'

[Nico, 2015-09-11 23:26:43]

That's a P0 bug on crashpad then. Projects outside of src/ are not allowed to
depend on base. (see http://crbug.com/468375 for a similar issue.)

[danakj, 2015-09-11 23:32:06]

PTAL

[danakj, 2015-09-11 23:32:54]

On 2015/09/11 23:32:06, danakj wrote:
> PTAL

Er, wrong CL. I'm fixing crashpad :)

Oh, really?

Crashpad is a Chromium project. Most of its development practices follow
Chromium’s. In order to function on its own in other projects, Crashpad uses
mini_chromium, a small, self-contained library that provides many of Chromium’s
useful low-level base routines. mini_chromium’s README provides more detail.

http://docs.crashpad.googlecode.com/git/doc/developing.html

[Nico, 2015-09-11 23:34:58]

On 2015/09/11 23:32:54, danakj wrote:
> On 2015/09/11 23:32:06, danakj wrote:
> > PTAL
> 
> Er, wrong CL. I'm fixing crashpad :)
> 
> Oh, really?
> 
> Crashpad is a Chromium project. Most of its development practices follow
> Chromium’s. In order to function on its own in other projects, Crashpad uses
> mini_chromium, a small, self-contained library that provides many of
Chromium’s
> useful low-level base routines. mini_chromium’s README provides more detail.
> 
> http://docs.crashpad.googlecode.com/git/doc/developing.html

Yes. If it's not in src/ it must not depend on base (to prevent dependency
issues like in this CL).

[Adam Rice, 2015-09-14 05:30:29]

https://codereview.chromium.org/1340683002/diff/100001/base/memory/scoped_ptr.h
File base/memory/scoped_ptr.h (right):

https://codereview.chromium.org/1340683002/diff/100001/base/memory/scoped_ptr...
base/memory/scoped_ptr.h:470: //   NOT use const_cast<Base*>() to upcast the
static type of the array.
While it's technically true that you MUST NOT use const_cast<Base*>() to upcast
the static type of the array, it's a little bit irrelevant because it won't
compile.

I think because this sentence is meaningless now it would probably be best just
to remove it.

[danakj, 2015-09-14 18:02:36]

https://codereview.chromium.org/1340683002/diff/100001/base/memory/scoped_ptr.h
File base/memory/scoped_ptr.h (right):

https://codereview.chromium.org/1340683002/diff/100001/base/memory/scoped_ptr...
base/memory/scoped_ptr.h:470: //   NOT use const_cast<Base*>() to upcast the
static type of the array.
On 2015/09/14 05:30:29, Adam Rice wrote:
> While it's technically true that you MUST NOT use const_cast<Base*>() to
upcast
> the static type of the array, it's a little bit irrelevant because it won't
> compile.
> 
> I think because this sentence is meaningless now it would probably be best
just
> to remove it.

Right.. yah okay. Done, thanks for looking.

[danakj, 2015-09-14 20:02:35]

The CQ bit was checked by danakj@chromium.org

[danakj, 2015-09-14 20:02:35]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org,
vmpstr@chromium.org, jsbell@chromium.org, rsleevi@chromium.org,
boliu@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1340683002/#ps120001
(title: "implicitcast: .")

[commit-bot: I haz the power, 2015-09-14 20:03:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1340683002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1340683002/120001

[commit-bot: I haz the power, 2015-09-14 21:10:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-14 21:10:10]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[danakj, 2015-09-14 21:15:30]

Hm.. that wasn't enough, or I messed something up. Still seeing:
../../third_party/crashpad/crashpad/util/mach/child_port_handshake.cc:104:34:error:
use of undeclared identifier 'implicit_cast'

[Nico, 2015-09-14 21:17:58]

On 2015/09/14 21:15:30, danakj wrote:
> Hm.. that wasn't enough, or I messed something up. Still seeing:
>
../../third_party/crashpad/crashpad/util/mach/child_port_handshake.cc:104:34:error:
> use of undeclared identifier 'implicit_cast'

Isn't that because of http://crbug.com/472900 ? crashpad (illegally) depends on
our base and uses stuff from our headers. You're removing said stuff. I guess
you'd have to first remove the implicit_cast use in crashpad, roll that in, and
then roll this. Or just move crashpad into the chromium repo and then change it
in this cl too (which is what  http://crbug.com/472900 is about – strange that
it's not fixed yet :-( )

[danakj, 2015-09-14 21:27:16]

On Mon, Sep 14, 2015 at 2:17 PM, <thakis@chromium.org> wrote:

> On 2015/09/14 21:15:30, danakj wrote:
>
>> Hm.. that wasn't enough, or I messed something up. Still seeing:
>>
>
>
>
../../third_party/crashpad/crashpad/util/mach/child_port_handshake.cc:104:34:error:
>
>> use of undeclared identifier 'implicit_cast'
>>
>
> Isn't that because of http://crbug.com/472900 ? crashpad (illegally)
> depends on
> our base and uses stuff from our headers. You're removing said stuff. I
> guess
> you'd have to first remove the implicit_cast use in crashpad, roll that
> in, and
> then roll this. Or just move crashpad into the chromium repo and then
> change it
>

Yah, I added an implicit_cast inside crashpad to replace this one (in the
crashpad namespace). Cuz they didn't want to use static cast instead. And
rolled it. But.. did something wrong:
https://codereview.chromium.org/1335353002/


> in this cl too (which is what  http://crbug.com/472900 is about – strange
> that
> it's not fixed yet :-( )
>
> https://codereview.chromium.org/1340683002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[danakj, 2015-09-14 21:28:24]

On 2015/09/14 21:27:16, danakj wrote:
> Yah, I added an implicit_cast inside crashpad to replace this one (in the
> crashpad namespace). Cuz they didn't want to use static cast instead. And
> rolled it. But.. did something wrong:
> https://codereview.chromium.org/1335353002/

Looks like I just missed including implicit_cast.h in some more files, maybe.

[danakj, 2015-09-14 21:37:45]

On 2015/09/14 21:28:24, danakj wrote:
> On 2015/09/14 21:27:16, danakj wrote:
> > Yah, I added an implicit_cast inside crashpad to replace this one (in the
> > crashpad namespace). Cuz they didn't want to use static cast instead. And
> > rolled it. But.. did something wrong:
> > https://codereview.chromium.org/1335353002/
> 
> Looks like I just missed including implicit_cast.h in some more files, maybe.

Hopefully https://codereview.chromium.org/1344683002/ gets them all now.
According to my grep-fu it should.

[danakj, 2015-09-14 22:17:13]

Patchset #8 (id:140001) has been deleted

[danakj, 2015-09-14 22:32:06]

On 2015/09/14 21:37:45, danakj wrote:
> On 2015/09/14 21:28:24, danakj wrote:
> > On 2015/09/14 21:27:16, danakj wrote:
> > > Yah, I added an implicit_cast inside crashpad to replace this one (in the
> > > crashpad namespace). Cuz they didn't want to use static cast instead. And
> > > rolled it. But.. did something wrong:
> > > https://codereview.chromium.org/1335353002/
> > 
> > Looks like I just missed including implicit_cast.h in some more files,
maybe.
> 
> Hopefully https://codereview.chromium.org/1344683002/ gets them all now.
> According to my grep-fu it should.

DEPS roll is over here https://codereview.chromium.org/1345613002/ then I try
land again.

[danakj, 2015-09-15 00:20:01]

The CQ bit was checked by danakj@chromium.org

[danakj, 2015-09-15 00:20:02]

The patchset sent to the CQ was uploaded after l-g-t-m from vmpstr@chromium.org,
jsbell@chromium.org, rsleevi@chromium.org, boliu@chromium.org,
thakis@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1340683002/#ps120001
(title: "implicitcast: .")

[commit-bot: I haz the power, 2015-09-15 00:20:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1340683002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1340683002/120001

[commit-bot: I haz the power, 2015-09-15 01:01:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-15 01:01:47]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[danakj, 2015-09-15 18:08:04]

The CQ bit was checked by danakj@chromium.org

[danakj, 2015-09-15 18:08:04]

The patchset sent to the CQ was uploaded after l-g-t-m from vmpstr@chromium.org,
jsbell@chromium.org, rsleevi@chromium.org, boliu@chromium.org,
thakis@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1340683002/#ps160001
(title: "implicitcast: numericstest")

[commit-bot: I haz the power, 2015-09-15 18:08:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1340683002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1340683002/160001

[commit-bot: I haz the power, 2015-09-15 20:27:34]

Committed patchset #8 (id:160001)

[commit-bot: I haz the power, 2015-09-15 20:28:10]

Patchset 8 (id:??) landed as
https://crrev.com/a5f0d96bc4f40971fc82e0b2255e27056d4621d1
Cr-Commit-Position: refs/heads/master@{#348978}

[commit-bot: I haz the power, 2015-09-23 12:48:55]

Patchset 8 (id:??) landed as
https://crrev.com/a5f0d96bc4f40971fc82e0b2255e27056d4621d1
Cr-Commit-Position: refs/heads/master@{#348978}