Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Unified Diff: chrome/browser/apps/app_shim/app_shim_host_mac_unittest.cc

Issue 1340683002: Remove base's implicit_cast. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: implicitcast: numericstest Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/apps/app_shim/app_shim_host_mac_unittest.cc
diff --git a/chrome/browser/apps/app_shim/app_shim_host_mac_unittest.cc b/chrome/browser/apps/app_shim/app_shim_host_mac_unittest.cc
index e20a9b5fcb2ed5b18c5bba6e39f7cf80a01cce9d..9a79097994cd7e4fdb7c0ad9f1425e5446cf41f3 100644
--- a/chrome/browser/apps/app_shim/app_shim_host_mac_unittest.cc
+++ b/chrome/browser/apps/app_shim/app_shim_host_mac_unittest.cc
@@ -78,7 +78,7 @@ class AppShimHostTest : public testing::Test,
}
void SimulateDisconnect() {
- implicit_cast<IPC::Listener*>(host_.release())->OnChannelError();
+ static_cast<IPC::Listener*>(host_.release())->OnChannelError();
}
protected:
@@ -128,7 +128,7 @@ TEST_F(AppShimHostTest, TestLaunchAppWithHandler) {
apps::AppShimHandler::RegisterHandler(kTestAppId, this);
LaunchApp(apps::APP_SHIM_LAUNCH_NORMAL);
EXPECT_EQ(kTestAppId,
- implicit_cast<apps::AppShimHandler::Host*>(host())->GetAppId());
+ static_cast<apps::AppShimHandler::Host*>(host())->GetAppId());
EXPECT_EQ(apps::APP_SHIM_LAUNCH_SUCCESS, GetLaunchResult());
EXPECT_EQ(1, launch_count_);
EXPECT_EQ(1, launch_now_count_);
@@ -136,8 +136,8 @@ TEST_F(AppShimHostTest, TestLaunchAppWithHandler) {
EXPECT_EQ(0, close_count_);
// A second OnAppLaunchComplete is ignored.
- implicit_cast<apps::AppShimHandler::Host*>(host())->
- OnAppLaunchComplete(apps::APP_SHIM_LAUNCH_APP_NOT_FOUND);
+ static_cast<apps::AppShimHandler::Host*>(host())
+ ->OnAppLaunchComplete(apps::APP_SHIM_LAUNCH_APP_NOT_FOUND);
EXPECT_EQ(apps::APP_SHIM_LAUNCH_SUCCESS, GetLaunchResult());
EXPECT_TRUE(host()->ReceiveMessage(
@@ -157,7 +157,7 @@ TEST_F(AppShimHostTest, TestNoLaunchNow) {
apps::AppShimHandler::RegisterHandler(kTestAppId, this);
LaunchApp(apps::APP_SHIM_LAUNCH_REGISTER_ONLY);
EXPECT_EQ(kTestAppId,
- implicit_cast<apps::AppShimHandler::Host*>(host())->GetAppId());
+ static_cast<apps::AppShimHandler::Host*>(host())->GetAppId());
EXPECT_EQ(apps::APP_SHIM_LAUNCH_SUCCESS, GetLaunchResult());
EXPECT_EQ(1, launch_count_);
EXPECT_EQ(0, launch_now_count_);
« no previous file with comments | « base/numerics/safe_numerics_unittest.cc ('k') | chrome/browser/ui/views/apps/chrome_native_app_window_views_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698