Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(804)

Unified Diff: net/tools/flip_server/url_utilities_unittest.cc

Issue 1340683002: Remove base's implicit_cast. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: implicitcast: numericstest Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/tools/flip_server/url_utilities_unittest.cc
diff --git a/net/tools/flip_server/url_utilities_unittest.cc b/net/tools/flip_server/url_utilities_unittest.cc
index cd44f9ce02fef05e299f2d059d8d9f19b2518017..b766c6cf3abe46cc67881811a5517c7b45038061 100644
--- a/net/tools/flip_server/url_utilities_unittest.cc
+++ b/net/tools/flip_server/url_utilities_unittest.cc
@@ -61,7 +61,7 @@ TEST(UrlUtilitiesTest, Unescape) {
"%2B%3D%7B%5B%7D%5D%7C%5C%3A%3B%22%27%3C%2C"
"%3E%2E%3F%2F"));
for (int c = 0; c < 256; ++c) {
- std::string unescaped_char(1, implicit_cast<unsigned char>(c));
+ std::string unescaped_char(1, static_cast<unsigned char>(c));
std::string escaped_char = base::StringPrintf("%%%02X", c);
EXPECT_EQ(unescaped_char, UrlUtilities::Unescape(escaped_char))
<< "escaped_char = " << escaped_char;
@@ -75,7 +75,7 @@ TEST(UrlUtilitiesTest, Unescape) {
UrlUtilities::Unescape("~`!@#$^&*()_-+={[}]|\\:;\"'<,>.?/"));
for (int c = 0; c < 256; ++c) {
if (c != '%') {
- std::string just_char(1, implicit_cast<unsigned char>(c));
+ std::string just_char(1, static_cast<unsigned char>(c));
EXPECT_EQ(just_char, UrlUtilities::Unescape(just_char));
}
}
« no previous file with comments | « net/disk_cache/simple/simple_version_upgrade_unittest.cc ('k') | net/tools/quic/quic_client_session_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698