Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Side by Side Diff: ui/base/page_transition_types.cc

Issue 1340683002: Remove base's implicit_cast. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: implicitcast: . Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/base/page_transition_types.h" 5 #include "ui/base/page_transition_types.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 8
9 namespace ui { 9 namespace ui {
10 10
11 bool PageTransitionCoreTypeIs(PageTransition lhs, 11 bool PageTransitionCoreTypeIs(PageTransition lhs,
12 PageTransition rhs) { 12 PageTransition rhs) {
13 // Expect the rhs to be a compile time constant without qualifiers. 13 // Expect the rhs to be a compile time constant without qualifiers.
14 DCHECK(PageTransitionGetQualifier(rhs) == 0 && 14 DCHECK(PageTransitionGetQualifier(rhs) == 0 &&
15 PageTransitionIsValidType(rhs)); 15 PageTransitionIsValidType(rhs));
16 return implicit_cast<int>(PageTransitionStripQualifier(lhs)) == 16 return static_cast<int>(PageTransitionStripQualifier(lhs)) ==
vmpstr 2015/09/11 21:31:16 This looks like an enum-to-same-enum comparison, s
danakj 2015/09/11 21:33:30 Ya I agree.
17 implicit_cast<int>(PageTransitionStripQualifier(rhs)); 17 static_cast<int>(PageTransitionStripQualifier(rhs));
18 } 18 }
19 19
20 PageTransition PageTransitionStripQualifier(PageTransition type) { 20 PageTransition PageTransitionStripQualifier(PageTransition type) {
21 return static_cast<PageTransition>(type & ~PAGE_TRANSITION_QUALIFIER_MASK); 21 return static_cast<PageTransition>(type & ~PAGE_TRANSITION_QUALIFIER_MASK);
22 } 22 }
23 23
24 bool PageTransitionIsValidType(int32 type) { 24 bool PageTransitionIsValidType(int32 type) {
25 PageTransition t = PageTransitionStripQualifier( 25 PageTransition t = PageTransitionStripQualifier(
26 static_cast<PageTransition>(type)); 26 static_cast<PageTransition>(type));
27 return (t <= PAGE_TRANSITION_LAST_CORE); 27 return (t <= PAGE_TRANSITION_LAST_CORE);
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 case PAGE_TRANSITION_AUTO_TOPLEVEL: return "auto_toplevel"; 80 case PAGE_TRANSITION_AUTO_TOPLEVEL: return "auto_toplevel";
81 case PAGE_TRANSITION_FORM_SUBMIT: return "form_submit"; 81 case PAGE_TRANSITION_FORM_SUBMIT: return "form_submit";
82 case PAGE_TRANSITION_RELOAD: return "reload"; 82 case PAGE_TRANSITION_RELOAD: return "reload";
83 case PAGE_TRANSITION_KEYWORD: return "keyword"; 83 case PAGE_TRANSITION_KEYWORD: return "keyword";
84 case PAGE_TRANSITION_KEYWORD_GENERATED: return "keyword_generated"; 84 case PAGE_TRANSITION_KEYWORD_GENERATED: return "keyword_generated";
85 } 85 }
86 return NULL; 86 return NULL;
87 } 87 }
88 88
89 } // namespace ui 89 } // namespace ui
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698