components/history/core/browser/history_backend.cc - Issue 1340683002: Remove base's implicit_cast.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/history/core/browser/history_backend.cc

Issue 1340683002: Remove base's implicit_cast. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: implicitcast: numericstest Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/history/core/browser/history_backend.cc

diff --git a/components/history/core/browser/history_backend.cc b/components/history/core/browser/history_backend.cc

index ad61094c5702e56dddce0ef178a7d0071ac5969f..19836b7f168bc448937a19d2e08d1a76e0c6ff70 100644

--- a/components/history/core/browser/history_backend.cc

+++ b/components/history/core/browser/history_backend.cc

@@ -1367,7 +1367,8 @@ void HistoryBackend::QueryFilteredURLs(int result_count,

// Limit to the top |result_count| results.

std::sort(data.begin(), data.end(), PageUsageData::Predicate);

- if (result_count && implicit_cast<int>(data.size()) > result_count)

+ DCHECK_GE(result_count, 0);

+ if (result_count && data.size() > static_cast<size_t>(result_count))

data.resize(result_count);

for (size_t i = 0; i < data.size(); ++i) {