Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: net/disk_cache/simple/simple_index_file_unittest.cc

Issue 1340683002: Remove base's implicit_cast. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: implicitcast: numericstest Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/disk_cache/simple/simple_index_file.cc ('k') | net/disk_cache/simple/simple_synchronous_entry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/disk_cache/simple/simple_index_file_unittest.cc
diff --git a/net/disk_cache/simple/simple_index_file_unittest.cc b/net/disk_cache/simple/simple_index_file_unittest.cc
index cfff0792f9a887c560026fe4bc461c5f8eb60403..ae4945a045b3c6bf7481d3f31b34ca4ef3b94572 100644
--- a/net/disk_cache/simple/simple_index_file_unittest.cc
+++ b/net/disk_cache/simple/simple_index_file_unittest.cc
@@ -221,9 +221,8 @@ TEST_F(SimpleIndexFileTest, LoadCorruptIndex) {
ASSERT_TRUE(simple_index_file.CreateIndexFileDirectory());
const base::FilePath& index_path = simple_index_file.GetIndexFilePath();
const std::string kDummyData = "nothing to be seen here";
- EXPECT_EQ(
- implicit_cast<int>(kDummyData.size()),
- base::WriteFile(index_path, kDummyData.data(), kDummyData.size()));
+ EXPECT_EQ(static_cast<int>(kDummyData.size()),
+ base::WriteFile(index_path, kDummyData.data(), kDummyData.size()));
base::Time fake_cache_mtime;
ASSERT_TRUE(simple_util::GetMTime(simple_index_file.GetIndexFilePath(),
&fake_cache_mtime));
@@ -263,9 +262,8 @@ TEST_F(SimpleIndexFileTest, SimpleCacheUpgrade) {
const std::string index_file_contents("incorrectly serialized data");
const base::FilePath old_index_file =
cache_path.AppendASCII("the-real-index");
- ASSERT_EQ(implicit_cast<int>(index_file_contents.size()),
- base::WriteFile(old_index_file,
- index_file_contents.data(),
+ ASSERT_EQ(static_cast<int>(index_file_contents.size()),
+ base::WriteFile(old_index_file, index_file_contents.data(),
index_file_contents.size()));
// Upgrade the cache.
« no previous file with comments | « net/disk_cache/simple/simple_index_file.cc ('k') | net/disk_cache/simple/simple_synchronous_entry.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698