base/files/file_unittest.cc - Issue 1340683002: Remove base's implicit_cast.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/files/file_unittest.cc

Issue 1340683002: Remove base's implicit_cast. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: implicitcast: numericstest Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/files/file_unittest.cc

diff --git a/base/files/file_unittest.cc b/base/files/file_unittest.cc

index 5c594242bc84867ec80a41f97465c6a486e19aee..3d60b2c870fc72a36738413c32b8167137cf140b 100644

--- a/base/files/file_unittest.cc

+++ b/base/files/file_unittest.cc

@@ -517,7 +517,7 @@ TEST(FileTest, MemoryCorruption) {

// Test that changing the checksum value is detected.

base::File file;

EXPECT_NE(file.file_.file_memory_checksum_,

- implicit_cast<unsigned int>(file.GetPlatformFile()));

+ static_cast<unsigned int>(file.GetPlatformFile()));

file.file_.file_memory_checksum_ = file.GetPlatformFile();

EXPECT_DEATH(file.IsValid(), "");

« no previous file with comments | « base/android/scoped_java_ref.h ('k') | base/macros.h » ('j') | no next file with comments »