components/history/core/browser/visitsegment_database.cc - Issue 1340683002: Remove base's implicit_cast.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/history/core/browser/visitsegment_database.cc

Issue 1340683002: Remove base's implicit_cast. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: implicitcast: numericstest Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/history/core/browser/visitsegment_database.cc

diff --git a/components/history/core/browser/visitsegment_database.cc b/components/history/core/browser/visitsegment_database.cc

index afeecb71441946eafbdbce5c4b15c9a4320d3106..232e044258d68e678daea8ed9eb96ca8ef3c0a0d 100644

--- a/components/history/core/browser/visitsegment_database.cc

+++ b/components/history/core/browser/visitsegment_database.cc

@@ -258,7 +258,8 @@ void VisitSegmentDatabase::QuerySegmentUsage(

// Limit to the top kResultCount results.

std::sort(results->begin(), results->end(), PageUsageData::Predicate);

- if (static_cast<int>(results->size()) > max_result_count) {

+ DCHECK_GE(max_result_count, 0);

+ if (results->size() > static_cast<size_t>(max_result_count)) {

STLDeleteContainerPointers(results->begin() + max_result_count,

results->end());

results->resize(max_result_count);