Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1333273003: Start trying to collapse path program stuff (Closed)

Created:
5 years, 3 months ago by joshua.litt
Modified:
5 years, 3 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@removebt
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Start trying to collapse path program stuff BUG=skia: Committed: https://skia.googlesource.com/skia/+/e7afc2d85ba1db71ef8938ce3459cd78b30f71db

Patch Set 1 #

Total comments: 1

Patch Set 2 : tweaks #

Patch Set 3 : windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -116 lines) Patch
M gyp/gpu.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLGeometryProcessor.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLGeometryProcessor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLPathProcessor.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLPathProgramDataManager.h View 1 chunk +1 line, -21 lines 0 comments Download
M src/gpu/gl/GrGLPathProgramDataManager.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M src/gpu/gl/GrGLPrimitiveProcessor.h View 1 1 chunk +3 lines, -22 lines 0 comments Download
M src/gpu/gl/GrGLProgramDataManager.h View 1 chunk +14 lines, -23 lines 0 comments Download
M src/gpu/gl/GrGLProgramDataManager.cpp View 14 chunks +14 lines, -15 lines 0 comments Download
D src/gpu/gl/GrGLUniformHandle.h View 1 chunk +0 lines, -15 lines 0 comments Download
M src/gpu/gl/builders/GrGLPathProgramBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 3 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
joshualitt
If this is controversial I can add a 'type' to ShaderResourceHandle
5 years, 3 months ago (2015-09-11 15:04:38 UTC) #2
bsalomon
lgtm w/ nit https://codereview.chromium.org/1333273003/diff/1/src/gpu/gl/GrGLPrimitiveProcessor.h File src/gpu/gl/GrGLPrimitiveProcessor.h (right): https://codereview.chromium.org/1333273003/diff/1/src/gpu/gl/GrGLPrimitiveProcessor.h#newcode77 src/gpu/gl/GrGLPrimitiveProcessor.h:77: GrGLProgramDataManager::UniformHandle fHandle; align
5 years, 3 months ago (2015-09-11 17:16:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1333273003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1333273003/20001
5 years, 3 months ago (2015-09-11 17:35:26 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/3194) Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, ...
5 years, 3 months ago (2015-09-11 17:37:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1333273003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1333273003/40001
5 years, 3 months ago (2015-09-11 17:38:15 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-11 17:44:17 UTC) #12
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/e7afc2d85ba1db71ef8938ce3459cd78b30f71db

Powered by Google App Engine
This is Rietveld 408576698