Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2035)

Issue 1316843006: Revert of Un-nest configs in GN files. (Closed)

Created:
5 years, 3 months ago by Nico
Modified:
5 years, 3 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, jzern, vikasa, urvang, skal, rouslan+spellwatch_chromium.org, rlp+watch_chromium.org, groby+spellwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Un-nest configs in GN files. (patchset #3 id:40001 of https://codereview.chromium.org/1318823008/ ) Reason for revert: This breaks why these configs exist in the first place and seriously breaks the clang/win gn build (which is what these configs exist for). Original issue's description: > Un-nest configs in GN files. > > People sometimes nest targets or configs, usually with the assumption that this limits the visibility of a config to within a target. But this nesting provides no visibility restrictions over declaring it outside of a block. > > Un-nest for clarity. > > Committed: https://crrev.com/4af2eac8e84692d94f88504ab6e0b244b88dddcb > Cr-Commit-Position: refs/heads/master@{#346461} TBR=dpranke@chromium.org,brettw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/0cb5abbf230f3c30e3499d4e787f059ed723dd3c Cr-Commit-Position: refs/heads/master@{#346695}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+251 lines, -284 lines) Patch
M build/secondary/testing/gtest/BUILD.gn View 2 chunks +8 lines, -9 lines 0 comments Download
M sdch/BUILD.gn View 2 chunks +12 lines, -12 lines 0 comments Download
M third_party/brotli/BUILD.gn View 2 chunks +10 lines, -13 lines 0 comments Download
M third_party/cld_2/BUILD.gn View 2 chunks +8 lines, -12 lines 0 comments Download
M third_party/harfbuzz-ng/BUILD.gn View 3 chunks +31 lines, -34 lines 0 comments Download
M third_party/hunspell/BUILD.gn View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/libpng/BUILD.gn View 2 chunks +8 lines, -9 lines 0 comments Download
M third_party/libusb/BUILD.gn View 2 chunks +9 lines, -11 lines 0 comments Download
M third_party/libwebp/BUILD.gn View 2 chunks +6 lines, -7 lines 0 comments Download
M third_party/libxml/BUILD.gn View 3 chunks +34 lines, -36 lines 0 comments Download
M third_party/libxslt/BUILD.gn View 2 chunks +14 lines, -17 lines 0 comments Download
M third_party/lzma_sdk/BUILD.gn View 2 chunks +12 lines, -13 lines 0 comments Download
M third_party/mesa/BUILD.gn View 2 chunks +9 lines, -9 lines 0 comments Download
M third_party/snappy/BUILD.gn View 2 chunks +9 lines, -12 lines 0 comments Download
M third_party/sqlite/BUILD.gn View 2 chunks +20 lines, -21 lines 0 comments Download
M third_party/usrsctp/BUILD.gn View 2 chunks +9 lines, -12 lines 0 comments Download
M third_party/yasm/BUILD.gn View 3 chunks +31 lines, -32 lines 0 comments Download
M third_party/zlib/BUILD.gn View 3 chunks +15 lines, -19 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
Created Revert of Un-nest configs in GN files.
5 years, 3 months ago (2015-09-01 18:28:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316843006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316843006/1
5 years, 3 months ago (2015-09-01 18:29:20 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-01 18:30:29 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0cb5abbf230f3c30e3499d4e787f059ed723dd3c Cr-Commit-Position: refs/heads/master@{#346695}
5 years, 3 months ago (2015-09-01 18:31:04 UTC) #4
Dirk Pranke
5 years, 3 months ago (2015-09-01 18:39:02 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698