Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: third_party/libxslt/BUILD.gn

Issue 1316843006: Revert of Un-nest configs in GN files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/libxml/BUILD.gn ('k') | third_party/lzma_sdk/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 config("libxslt_config") { 5 config("libxslt_config") {
6 defines = [ "LIBXSLT_STATIC" ] 6 defines = [ "LIBXSLT_STATIC" ]
7 include_dirs = [ "." ] 7 include_dirs = [ "." ]
8 } 8 }
9 9
10 config("libxslt_warnings") {
11 if (is_clang) {
12 cflags = [
13 # libxslt stores a char[3] in a `const unsigned char*`.
14 "-Wno-pointer-sign",
15
16 # xsltDefaultRegion and xsltCalibrateTimestamps are only
17 # used with certain preprocessor defines set.
18 "-Wno-unused-function",
19 ]
20 }
21 }
22
23 static_library("libxslt") { 10 static_library("libxslt") {
24 sources = [ 11 sources = [
25 "libxslt/attributes.c", 12 "libxslt/attributes.c",
26 "libxslt/attributes.h", 13 "libxslt/attributes.h",
27 "libxslt/attrvt.c", 14 "libxslt/attrvt.c",
28 "libxslt/documents.c", 15 "libxslt/documents.c",
29 "libxslt/documents.h", 16 "libxslt/documents.h",
30 "libxslt/extensions.c", 17 "libxslt/extensions.c",
31 "libxslt/extensions.h", 18 "libxslt/extensions.h",
32 "libxslt/extra.c", 19 "libxslt/extra.c",
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 "libxslt/xsltlocale.c", 52 "libxslt/xsltlocale.c",
66 "libxslt/xsltlocale.h", 53 "libxslt/xsltlocale.h",
67 "libxslt/xsltutils.c", 54 "libxslt/xsltutils.c",
68 "libxslt/xsltutils.h", 55 "libxslt/xsltutils.h",
69 "libxslt/xsltwin32config.h", 56 "libxslt/xsltwin32config.h",
70 "linux/config.h", 57 "linux/config.h",
71 "mac/config.h", 58 "mac/config.h",
72 "win32/config.h", 59 "win32/config.h",
73 ] 60 ]
74 61
62 config("libxslt_warnings") {
63 if (is_clang) {
64 cflags = [
65 # libxslt stores a char[3] in a `const unsigned char*`.
66 "-Wno-pointer-sign",
67
68 # xsltDefaultRegion and xsltCalibrateTimestamps are only
69 # used with certain preprocessor defines set.
70 "-Wno-unused-function",
71 ]
72 }
73 }
75 configs -= [ "//build/config/compiler:chromium_code" ] 74 configs -= [ "//build/config/compiler:chromium_code" ]
76 configs += [ 75 configs += [ "//build/config/compiler:no_chromium_code" ]
77 ":libxslt_warnings", 76 configs += [ ":libxslt_warnings" ]
78 "//build/config/compiler:no_chromium_code",
79 ]
80 public_configs = [ ":libxslt_config" ] 77 public_configs = [ ":libxslt_config" ]
81 78
82 cflags = [] 79 cflags = []
83 if (is_linux || is_android) { 80 if (is_linux || is_android) {
84 include_dirs = [ "linux" ] 81 include_dirs = [ "linux" ]
85 } else if (is_win) { 82 } else if (is_win) {
86 include_dirs = [ "win32" ] 83 include_dirs = [ "win32" ]
87 cflags += [ "/wd4267" ] # size_t to int. 84 cflags += [ "/wd4267" ] # size_t to int.
88 } else if (is_mac) { 85 } else if (is_mac) {
89 include_dirs = [ "mac" ] 86 include_dirs = [ "mac" ]
90 } 87 }
91 88
92 deps = [ 89 deps = [
93 "//third_party/libxml", 90 "//third_party/libxml",
94 ] 91 ]
95 } 92 }
OLDNEW
« no previous file with comments | « third_party/libxml/BUILD.gn ('k') | third_party/lzma_sdk/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698