Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: third_party/libpng/BUILD.gn

Issue 1316843006: Revert of Un-nest configs in GN files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/hunspell/BUILD.gn ('k') | third_party/libusb/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/libpng/BUILD.gn
diff --git a/third_party/libpng/BUILD.gn b/third_party/libpng/BUILD.gn
index 21420596db7fcaae359799e594aec3d1e320947f..c4e2650c8ae6ab2a1e51d4d2ee9f43cc1126e4f7 100644
--- a/third_party/libpng/BUILD.gn
+++ b/third_party/libpng/BUILD.gn
@@ -22,15 +22,6 @@
"PNG_NO_MODULEDEF",
]
}
- }
-}
-
-# Must be in a config because of how GN orders flags (otherwise -Wall will
-# appear after this, and turn it back on).
-config("clang_warnings") {
- if (is_clang) {
- # Upstream uses self-assignment to avoid warnings.
- cflags = [ "-Wno-self-assign" ]
}
}
@@ -71,6 +62,14 @@
"//third_party/zlib",
]
+ # Must be in a config because of how GN orders flags (otherwise -Wall will
+ # appear after this, and turn it back on).
+ config("clang_warnings") {
+ if (is_clang) {
+ # Upstream uses self-assignment to avoid warnings.
+ cflags = [ "-Wno-self-assign" ]
+ }
+ }
configs += [ ":clang_warnings" ]
}
« no previous file with comments | « third_party/hunspell/BUILD.gn ('k') | third_party/libusb/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698