Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: third_party/hunspell/BUILD.gn

Issue 1316843006: Revert of Un-nest configs in GN files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/harfbuzz-ng/BUILD.gn ('k') | third_party/libpng/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 config("hunspell_config") { 5 config("hunspell_config") {
6 defines = [ 6 defines = [
7 "HUNSPELL_STATIC", 7 "HUNSPELL_STATIC",
8 "HUNSPELL_CHROME_CLIENT", 8 "HUNSPELL_CHROME_CLIENT",
9 "USE_HUNSPELL", 9 "USE_HUNSPELL",
10 ] 10 ]
11 } 11 }
12 12
13 config("hunspell_warnings") {
14 if (is_clang) {
15 cflags = [ "-Wno-unused-private-field" ]
16 }
17 }
18
19 source_set("hunspell") { 13 source_set("hunspell") {
20 sources = [ 14 sources = [
21 "google/bdict.cc", 15 "google/bdict.cc",
22 "google/bdict.h", 16 "google/bdict.h",
23 "google/bdict_reader.cc", 17 "google/bdict_reader.cc",
24 "google/bdict_reader.h", 18 "google/bdict_reader.h",
25 "google/bdict_writer.cc", 19 "google/bdict_writer.cc",
26 "google/bdict_writer.h", 20 "google/bdict_writer.h",
27 "src/hunspell/affentry.cxx", 21 "src/hunspell/affentry.cxx",
28 "src/hunspell/affentry.hxx", 22 "src/hunspell/affentry.hxx",
(...skipping 21 matching lines...) Expand all
50 "src/hunspell/replist.cxx", 44 "src/hunspell/replist.cxx",
51 "src/hunspell/replist.hxx", 45 "src/hunspell/replist.hxx",
52 "src/hunspell/suggestmgr.cxx", 46 "src/hunspell/suggestmgr.cxx",
53 "src/hunspell/suggestmgr.hxx", 47 "src/hunspell/suggestmgr.hxx",
54 "src/hunspell/utf_info.hxx", 48 "src/hunspell/utf_info.hxx",
55 "src/hunspell/w_char.hxx", 49 "src/hunspell/w_char.hxx",
56 "src/parsers/textparser.cxx", 50 "src/parsers/textparser.cxx",
57 "src/parsers/textparser.hxx", 51 "src/parsers/textparser.hxx",
58 ] 52 ]
59 53
54 config("hunspell_warnings") {
55 if (is_clang) {
56 cflags = [ "-Wno-unused-private-field" ]
57 }
58 }
59
60 configs -= [ "//build/config/compiler:chromium_code" ] 60 configs -= [ "//build/config/compiler:chromium_code" ]
61 configs += [ 61 configs += [
62 "//build/config/compiler:no_chromium_code", 62 "//build/config/compiler:no_chromium_code",
63 ":hunspell_warnings", 63 ":hunspell_warnings",
64 ] 64 ]
65 public_configs = [ ":hunspell_config" ] 65 public_configs = [ ":hunspell_config" ]
66 66
67 defines = [ "OPENOFFICEORG" ] 67 defines = [ "OPENOFFICEORG" ]
68 68
69 deps = [ 69 deps = [
(...skipping 30 matching lines...) Expand all
100 cflags += [ 100 cflags += [
101 # affentry.cxx has one `while ((p = nextchar(p)));` parsing loop. 101 # affentry.cxx has one `while ((p = nextchar(p)));` parsing loop.
102 "-Wno-empty-body", 102 "-Wno-empty-body",
103 103
104 # affentry.hxx has NULL as default parameter for a FLAG in two 104 # affentry.hxx has NULL as default parameter for a FLAG in two
105 # places. 105 # places.
106 "-Wno-null-conversion", 106 "-Wno-null-conversion",
107 ] 107 ]
108 } 108 }
109 } 109 }
OLDNEW
« no previous file with comments | « third_party/harfbuzz-ng/BUILD.gn ('k') | third_party/libpng/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698