Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: third_party/mesa/BUILD.gn

Issue 1316843006: Revert of Un-nest configs in GN files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/lzma_sdk/BUILD.gn ('k') | third_party/snappy/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/mesa/BUILD.gn
diff --git a/third_party/mesa/BUILD.gn b/third_party/mesa/BUILD.gn
index 3f27efce5fa17c8b3839ecd2bc875cc39e8b944b..40d63af00671a14e62ffa4fbb86bf7e106880d2a 100644
--- a/third_party/mesa/BUILD.gn
+++ b/third_party/mesa/BUILD.gn
@@ -144,15 +144,6 @@
"/wd4305", # Truncation from int to float.
"/wd4334", # Result of 32-bit shift implicitly converted to 64 bits.
"/wd4345", # POD-type default initializers.
- ]
- }
-}
-
-config("mesa_libglslcommon_warnings") {
- if (is_clang) {
- cflags = [
- # https://bugs.freedesktop.org/show_bug.cgi?id=91645:
- "-Wno-overloaded-virtual",
]
}
}
@@ -260,6 +251,15 @@
"src/src/glsl/strtod.c",
"src/src/glsl/strtod.h",
]
+
+ config("mesa_libglslcommon_warnings") {
+ if (is_clang) {
+ cflags = [
+ # https://bugs.freedesktop.org/show_bug.cgi?id=91645:
+ "-Wno-overloaded-virtual",
+ ]
+ }
+ }
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [ "//build/config/compiler:no_chromium_code" ]
« no previous file with comments | « third_party/lzma_sdk/BUILD.gn ('k') | third_party/snappy/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698