Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: third_party/snappy/BUILD.gn

Issue 1316843006: Revert of Un-nest configs in GN files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/mesa/BUILD.gn ('k') | third_party/sqlite/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/snappy/BUILD.gn
diff --git a/third_party/snappy/BUILD.gn b/third_party/snappy/BUILD.gn
index 8ab472d371c696b74c50001ece68fde4dcdf448a..97cce89bc719d8425d88b54a724bb0d758027c81 100644
--- a/third_party/snappy/BUILD.gn
+++ b/third_party/snappy/BUILD.gn
@@ -16,14 +16,6 @@
}
}
-config("snappy_warnings") {
- if (is_clang) {
- # ComputeTable is unused,
- # https://code.google.com/p/snappy/issues/detail?id=96
- cflags = [ "-Wno-unused-function" ]
- }
-}
-
static_library("snappy") {
sources = [
"src/snappy-internal.h",
@@ -35,11 +27,16 @@
"src/snappy.h",
]
+ config("snappy_warnings") {
+ if (is_clang) {
+ # ComputeTable is unused,
+ # https://code.google.com/p/snappy/issues/detail?id=96
+ cflags = [ "-Wno-unused-function" ]
+ }
+ }
configs -= [ "//build/config/compiler:chromium_code" ]
- configs += [
- ":snappy_warnings",
- "//build/config/compiler:no_chromium_code",
- ]
+ configs += [ "//build/config/compiler:no_chromium_code" ]
+ configs += [ ":snappy_warnings" ]
public_configs = [ ":snappy_config" ]
if (is_win) {
« no previous file with comments | « third_party/mesa/BUILD.gn ('k') | third_party/sqlite/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698