third_party/hunspell/BUILD.gn - Issue 1316843006: Revert of Un-nest configs in GN files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/hunspell/BUILD.gn

Issue 1316843006: Revert of Un-nest configs in GN files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/hunspell/BUILD.gn

diff --git a/third_party/hunspell/BUILD.gn b/third_party/hunspell/BUILD.gn

index 84f0ae76700c4e38a71081fa5e2eae6edc9cb8eb..9e9f249e5b31b59ee0ca12a8768d4e9db942da67 100644

--- a/third_party/hunspell/BUILD.gn

+++ b/third_party/hunspell/BUILD.gn

@@ -8,12 +8,6 @@

"HUNSPELL_CHROME_CLIENT",

"USE_HUNSPELL",

]

-config("hunspell_warnings") {

- if (is_clang) {

- cflags = [ "-Wno-unused-private-field" ]

- }

}

source_set("hunspell") {

@@ -56,6 +50,12 @@

"src/parsers/textparser.cxx",

"src/parsers/textparser.hxx",

]

+ config("hunspell_warnings") {

+ if (is_clang) {

+ cflags = [ "-Wno-unused-private-field" ]

+ }

configs -= [ "//build/config/compiler:chromium_code" ]

configs += [

« no previous file with comments | « third_party/harfbuzz-ng/BUILD.gn ('k') | third_party/libpng/BUILD.gn » ('j') | no next file with comments »